Skip to content

Refactor Subproject validation to use it for Forms and API #6285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2019
Merged

Refactor Subproject validation to use it for Forms and API #6285

merged 2 commits into from
Dec 1, 2019

Conversation

saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Oct 14, 2019 •
edited
Loading

@saadmk11 saadmk11 requested review from humitos and a team October 14, 2019 16:43
@stale
Copy link

stale bot commented Nov 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Nov 28, 2019
@saadmk11 saadmk11 removed the Status: stale Issue will be considered inactive soon label Nov 28, 2019
humitos
humitos approved these changes Dec 1, 2019
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@humitos humitos merged commit 659d72d into readthedocs:master Dec 1, 2019
@saadmk11 saadmk11 deleted the refactor-subproject-validation branch December 1, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saadmk11 @humitos