v3 API doesn't check if a subproject relationship already exists

[ghost]

Details

• Read the Docs project URL:
• Build URL (if applicable):
• Read the Docs username (if applicable):

Expected Result

Only one subproject relation should be allowed.

Actual Result

When creating a subproject relationship, the v3 API does not check that there is not already a relationship and will allow the creation. Also, once there is more than one relation to the same project, it can no longer be deleted via API or GUI.

[stsewd]

Looks like we allow that on the GUI too, we only modify the queryset, but we don't really check if the subproject is valid

readthedocs.org/readthedocs/rtd_tests/tests/test_subprojects.py

Line 130 in 2bd2dac

def test_excludes_existing_subprojects(self):

Also, once there is more than one relation to the same project, it can no longer be deleted via API or GUI.

You can do it from the edit button, does it give you an error?

[ghost]

You can do it from the edit button, does it give you an error?

Clicking the edit button gives me the fail whale.

[stsewd]

Which relationship do you want to delete? I can delete it manually for you.

[ghost]

Thanks, you can delete all four. Account lf-oran, under dwproj.

[stsewd]

Done, let me know if it looks correct now

[ghost]

It does, thanks.

…

On Thu, Oct 10, 2019 at 10:18 AM Santos Gallegos ***@***.***> wrote: Done, let me know if it looks correct now — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6271?email_source=notifications&email_token=AM3VBJNUHGPJYCNSF6MCD3TQN5PVVA5CNFSM4I7PFK22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA5DK5I#issuecomment-540685685>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AM3VBJP3GLOGHPYIQBFTAWDQN5PVVANCNFSM4I7PFK2Q> .

-- DW Talton Release Engineering The Linux Foundation

[humitos]

Good catch, @dwt2! Thanks for reporting this :)