Pass build env python limits to config object #2627
Conversation
* Pass in build env python limitations to config * Exposes parsing error to user on build output
agjohnson
added
PR: work in progress
readthedocs/doc_builder/constants.py
Outdated
| 'readthedocs/build:16.04': { | ||
| 'python': {'supported_versions': [2, 2.7, 3, 3.5]}, | ||
| }, | ||
| 'readthedocs/build:beta': { |
There was a problem hiding this comment.
Wonder if this should be given a more specific name? Seems like we'll want to do stuff over time where beta isn't really reflective of, and we don't want it to conflict.
There was a problem hiding this comment.
I was thinking about naming schemes myself, however I was considering how to make names more generic. I don't think it's important to have a 16.04 branch of names and a 14.04 branch of images. Perhaps we adopt semver versioning instead? I'll leave this for now, we can discuss versioning in the docker-images repo
There was a problem hiding this comment.
Tunes up tests, fixes a bug with logic on python version detection
|
I updated the tests to do a full test of our configuration, instead of just testing the readthedocs-build implementation. It should be pretty close to parity, but it did uncover a bug in python version detection. Might be worth a once over |
|
Looks good. |
agjohnson
removed
PR: ready for review
PR: work in progress
Requires readthedocs/readthedocs-build#21