Extend support for Python version validation #21
Conversation
* Allow for python supported versions to be passed into the config object. This is required to pass in per-build environment python versions for validation * More validation on lists * Don't handle strings as iterables in choice validation * Coerce Python verion to an int/float if possible
| @@ -149,6 +149,19 @@ Following mapping keys are supported (all but the marked once are optional): | |||
| The path in which ``python setup.py install`` will be executed. | |||
| Defaults to the repository root. | |||
|
|
|||
| ``version`` | |||
There was a problem hiding this comment.
Seems weird there's an example here that doesn't include the actual version object that it's documenting.
There was a problem hiding this comment.
This could be moved into docs on the actual config object, as it's not important for the spec. None of the elements have an example currently, so I don't think one is necessarily warranted here yet. I could see overhauling this doc to include more information eventually however.
| @@ -78,6 +78,8 @@ class BuildConfig(dict): | |||
| PYTHON_EXTRA_REQUIREMENTS_INVALID_MESSAGE = ( | |||
| '"python.extra_requirements" section must be a list.') | |||
|
|
|||
| PYTHON_SUPPORTED_VERSIONS = [2, 2.7, 3, 3.3, 3.4, 3.5, 3.6] | |||
There was a problem hiding this comment.
Do we want to support <3.5?
There was a problem hiding this comment.
I think this can be agnostic to what versions we actually support, this is just checking for valid version numbers ATM. This decision should be left up to our implementation on RTD, i think.
agjohnson
force-pushed
the
extend-py-version
branch
from
da08939 to
0c08e88
Compare
|
Failing tests are #22, won't fix them here. |
is required to pass in per-build environment python versions for validation
Refs readthedocs/readthedocs-docker-images#18