Skip to content

Adopt version numbers for tags #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agjohnson opened this issue Feb 4, 2017 · 2 comments
Closed

Adopt version numbers for tags #19

agjohnson opened this issue Feb 4, 2017 · 2 comments

Comments

@agjohnson
Copy link
Contributor

Currently, we have a hodgepodge of tags:

  • readthedocs/build:14.04
  • readthedocs/build:16.04
  • readthedocs/build:beta

However, these communicate nothing about the progression of the image. Instead, perhaps we adopt semver for versioning:

  • readthedocs/build:14.04 -> readthedocs/build:1.0, push to branch 1.x
  • readthedocs/build:16.04 -> readthedocs/build:2.0, push to branch 2.x
  • readthedocs/build:beta -> readthedocs/build:3.0, push to branch 3.x
  • Add support for multiple nodejs versions -> readthedocs/build:3.1, push to branch 3.x
  • Security patch release on 16.04 LTS -> readthedocs/build:3.1.1, push to branch 3.x
  • New LTS release, bump 3.1.1 -> readthedocs/build:4.0, push to branch 4.x

This will allow for multiple images to exist and be pulled down to the build servers for use. The repo layout will be a single Dockerfile with multiple branches/tags to handle versions. We could even possibly rely on docker automated builds here, to cut out the middle operation of building these images on a server and pushing them up.

@ericholscher
Copy link
Member

ericholscher commented Feb 4, 2017 via email

@agjohnson
Copy link
Contributor Author

I restructured the repo and set up https://hub.docker.com/r/readthedocs/build/ as an automated build. The versions are currently built from version tags, and latest is from master, so we'll get a new image on any push to master now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants