Git service: attach each service to an allauth provider #11995
Conversation
With #11942, a GH app is used to interact with the GH API, a GH app is not directly tied to a user, so this assumption is not valid anymore. For most of the operations (except for syncing repos), we don't need to know who is the user that is performing the action, we just need to know the project that is being affected.
stsewd
changed the title
| token_config.update( | ||
| { | ||
| "refresh_token": token.token_secret, | ||
| "expires_in": token_expires, |
There was a problem hiding this comment.
I'm a little surprised we're setting this internally -- is it so we can update it if needed?
There was a problem hiding this comment.
yeah, allauth doesn't provide an oauth2 client, so we use requests_oauthlib, and we need to glue the token from allauth other lib. Most of this code was just moved.
| """ | ||
| Update token given data from OAuth response. | ||
|
|
||
| Expect the following response into the closure:: |
There was a problem hiding this comment.
Not sure what this is saying -- do you mean that is the expected value of the token arg?
There was a problem hiding this comment.
Nope, this is likely the response you get when the request for a new token is made.
| log.info("Updated token.", token_id=token.pk) | ||
|
|
||
| return _updater | ||
| @cached_property |
There was a problem hiding this comment.
What is caching doing here? Seems a little scary to cache an object like this? Could probably use a comment at least explaining why we aren't just setting this in the __init__ as self.session?
There was a problem hiding this comment.
This is the same as we used to have (cache the client at the instance level), but we were manually caching the object.
readthedocs.org/readthedocs/oauth/services/base.py
Lines 164 to 167 in 2c963f1
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This is on top of #11983