Skip to content

Import: fix session #11997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Import: fix session #11997

merged 1 commit into from
Feb 17, 2025

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Feb 14, 2025

missed this one, looks like we don't have test for this code...

@stsewd stsewd requested a review from a team as a code owner February 14, 2025 03:33
@stsewd stsewd requested a review from humitos February 14, 2025 03:33
@humitos
Copy link
Member

humitos commented Feb 17, 2025

I'm not sure to understand this change. Do we have more context here?

@stsewd
Copy link
Member Author

stsewd commented Feb 17, 2025

get_session does no longer exist, it's just session now #11995.

@humitos
Copy link
Member

humitos commented Feb 17, 2025

OK. Found it! I would have appreciated if you sent me the link to the line code where it was changed https://github.com/readthedocs/readthedocs.org/pull/11995/files#diff-64f41072534684987c1bbed78005fc6b069b36cc7ab110c875f859ddba77c010R155

@stsewd stsewd merged commit 754bb25 into main Feb 17, 2025
8 checks passed
@stsewd stsewd deleted the fix-session branch February 17, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants