Git service: depend on the project instead of users #11983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With #11942, a GH app is used to interact with the GH API, a GH app is not directly tied to a user, so this assumption is not valid anymore. For most of the operations (except for syncing repos), we don't need to know who is the user that is performing the action, we just need to know the project that is being affected.
|
I'm marking this as blocked since I understand we need #11942 first. |
|
@humitos no, this change works without the other PR, it's ready for review. |
stsewd
commented
Feb 11, 2025
| return provider_class.name | ||
| return None | ||
| service_class = self.get_git_service_class(fallback_to_clone_url=True) | ||
| return service_class.provider_name if service_class else None |
There was a problem hiding this comment.
Should this return an empty string instead of None if it's used to display it?
There was a problem hiding this comment.
Doesn't look like this is being used for display (not directly), but to identify the type of provider... so this can probably be removed and callers should use get_git_service_class instead.
There was a problem hiding this comment.
Will do that in another PR, as returning none matches the current behavior.
ericholscher
approved these changes
Feb 13, 2025
stsewd
added a commit
that referenced
this pull request
Feb 14, 2025
- With #11942, there is the need to get an OAuth2 client from an account, so that method was moved outside the UserService class, and it just depends on the social account. - provider_id and provider name don't need to be an instance method, and can be extracted from the allauth provider attached to the service class. This is on top of #11983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #11942, a GH app is used to interact with the GH API,
a GH app is not directly tied to a user, so this assumption is not valid anymore.
For most of the operations (except for syncing repos), we don't need to know who is the user that is performing the action, we just need to know the project that is being affected.