Skip to content

Proxito: Search scope narrowed to active project (version, translation or subproject 404s) #10324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2023
Merged

Proxito: Search scope narrowed to active project (version, translation or subproject 404s) #10324

merged 2 commits into from
May 22, 2023

Conversation

benjaoming
Copy link
Contributor

Fixes #10292

@benjaoming benjaoming requested a review from stsewd May 17, 2023 11:33
@benjaoming benjaoming requested review from a team as code owners May 17, 2023 11:33
@benjaoming benjaoming requested a review from agjohnson May 17, 2023 11:33
@benjaoming benjaoming removed the request for review from agjohnson May 17, 2023 11:34
@benjaoming
Copy link
Contributor Author

benjaoming commented May 17, 2023 •
edited
Loading

  • Tested on versions
  • ...and subprojects ah, this is one that we aren't raising specific exceptions for yet
  • ...and translations

image

stsewd
stsewd approved these changes May 17, 2023
View reviewed changes
@benjaoming benjaoming merged commit 7de4d95 into main May 22, 2023
@benjaoming benjaoming deleted the benjaoming/version-project-in-404-context branch May 22, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd approved these changes

Assignees

@benjaoming benjaoming

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

404 pages: the project isn't included in the search box when a version isn't found
2 participants
@benjaoming @stsewd