Skip to content

Proxito: Search scope narrowed to active project (version, translation or subproject 404s) #10324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2023
Merged

Proxito: Search scope narrowed to active project (version, translation or subproject 404s) #10324

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cddfbc2
Search scope narrowed to active project when version, translation or …
benjaoming May 17, 2023
3054b6c
Update readthedocs/proxito/views/serve.py
benjaoming May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion readthedocs/proxito/views/serve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,7 @@ def get_using_unresolver(self, request, path):
if response:
return response

# No custom 404 page, use our contextualized 404 response
# No is custom 404 page, use our general contextualized 404 response
# Several additional context variables can be added if the templates
# or other error handling is developed (version, language, filename).
raise contextualized_404_class(
Expand Down
2 changes: 1 addition & 1 deletion readthedocs/templates/errors/404/no_language.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@

{% block 404_error_message %}
{% include "errors/404/include_error_message.html" %}
{% include "errors/404/include_search.html" %}
{% include "errors/404/include_search.html" with search_project=project.slug %}
{% include "errors/404/include_tips.html" %}
{% endblock %}
2 changes: 1 addition & 1 deletion readthedocs/templates/errors/404/no_subproject.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@

{% block 404_error_message %}
{% include "errors/404/include_error_message.html" %}
{% include "errors/404/include_search.html" %}
{% include "errors/404/include_search.html" with search_project=project.slug %}
{% include "errors/404/include_tips.html" %}
{% endblock %}
2 changes: 1 addition & 1 deletion readthedocs/templates/errors/404/no_version.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@

{% block 404_error_message %}
{% include "errors/404/include_error_message.html" %}
{% include "errors/404/include_search.html" %}
{% include "errors/404/include_search.html" with search_project=project.slug %}
{% include "errors/404/include_tips.html" %}
{% endblock %}