Skip to content

Use doctype from search result instead of querying it from the db #7762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stsewd opened this issue Dec 16, 2020 · 0 comments · Fixed by #7984
Closed

Use doctype from search result instead of querying it from the db #7762

stsewd opened this issue Dec 16, 2020 · 0 comments · Fixed by #7984
Labels
Improvement Minor improvement to code

Comments

@stsewd
Copy link
Member

stsewd commented Dec 16, 2020

After #7757 we are tracking the doctype in the documents, so we no longer require to query that from the db. This requires a re-index before start using it.
@stsewd stsewd added Improvement Minor improvement to code Status: blocked Issue is blocked on another issue labels Dec 16, 2020
@stsewd stsewd mentioned this issue Dec 16, 2020
Merged
@stsewd stsewd removed the Status: blocked Issue is blocked on another issue label Mar 3, 2021
stsewd added a commit that referenced this issue Mar 4, 2021
@stsewd
Search: use doctype from indexed pages instead of the db
9754c47 
Since we did a re-index, we can use this value from the page instead
of querying from the db, now all results will have correct urls for the
given doctype :)

Closes #7762
@stsewd stsewd mentioned this issue Mar 4, 2021
Merged
stsewd added a commit that referenced this issue Mar 4, 2021
@stsewd
Search: use doctype from indexed pages instead of the db (#7984)
33cb887 
Since we did a re-index, we can use this value from the page instead
of querying from the db, now all results will have correct urls for the
given doctype :)

Closes #7762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Search: use doctype from indexed pages instead of the db readthedocs/readthedocs.org
1 participant
@stsewd