Search: use alias to link to search results of subprojects #7757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we are showing `(result from {subproject_slug})`
instead of the chosen alias.
With this now we can show the proper alias.
Also, start tracking the doctype of the version (it changes when the
version changes so we are good).
With this we can have the correct urls for all projects
https://github.com/readthedocs/readthedocs.org/blob/1675fd3ea55947ef1de681c87df625ff5bc43abd/readthedocs/search/serializers.py#L113
stsewd
changed the title
stsewd
force-pushed
the
search/use-alias-for-subprojects
branch
from
4b40524 to
05cc10a
Compare
| @@ -69,6 +69,7 @@ class PageDocument(RTDDocTypeMixin, Document): | |||
| # Metadata | |||
| project = fields.KeywordField(attr='project.slug') | |||
| version = fields.KeywordField(attr='version.slug') | |||
| doctype = fields.KeywordField(attr='version.documentation_type') | |||
There was a problem hiding this comment.
Does this require reindexing?
There was a problem hiding this comment.
yeah, but we can do it the next year, we aren't using it yet (still querying from the db or falling back to None). Tracking it here #7762.
Yeah, I was thinking about having a structure like |
stsewd
force-pushed
the
search/use-alias-for-subprojects
branch
from
b179719 to
33ed079
Compare
|
I have changed it to use another structure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are showing
(result from {subproject_slug})instead of the chosen alias.
With this now we can show the proper alias. The alias is tracked in the VersionData namedtuple that is passed into the context.
Also, start tracking the doctype of the version (it changes when the
version changes so we are good).
With this we can have the correct urls for all projects
readthedocs.org/readthedocs/search/serializers.py
Line 113 in 1675fd3