Skip to content

Search: use doctype from indexed pages instead of the db #7984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Mar 4, 2021

Since we did a re-index, we can use this value from the page instead
of querying from the db, now all results will have correct urls for the
given doctype :)

Closes #7762

Since we did a re-index, we can use this value from the page instead
of querying from the db, now all results will have correct urls for the
given doctype :)

Closes #7762
@stsewd
Copy link
Member Author

stsewd commented Mar 4, 2021

@stsewd stsewd requested a review from ericholscher March 4, 2021 16:26
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, it doesn't change the API response right, just our internal code?

@stsewd
Copy link
Member Author

stsewd commented Mar 4, 2021

it doesn't change the API response right, just our internal code?

yep

@stsewd stsewd merged commit 33cb887 into master Mar 4, 2021
@stsewd stsewd deleted the search-doctype branch March 4, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use doctype from search result instead of querying it from the db
2 participants