Skip to content

Add support for Ruby via asdf #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Add support for Ruby via asdf #200

merged 2 commits into from
Feb 1, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented Jan 29, 2024

humitos added a commit to readthedocs/readthedocs.org that referenced this pull request Jan 29, 2024
@@ -1,7 +1,7 @@
# Read the Docs - Environment base
FROM ubuntu:22.04
LABEL mantainer="Read the Docs <[email protected]>"
LABEL version="ubuntu-22.04-2023.03.09"
LABEL version="ubuntu-22.04-2024.01.29"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to re-build ubuntu-20.04 as well to install the Ruby plugin on asdf.

Copy link
Member

@ericholscher ericholscher Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium scary... hopefully it doesn't break anything :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #201 for this.

@@ -1,7 +1,7 @@
# Read the Docs - Environment base
FROM ubuntu:22.04
LABEL mantainer="Read the Docs <[email protected]>"
LABEL version="ubuntu-22.04-2023.03.09"
LABEL version="ubuntu-22.04-2024.01.29"
Copy link
Member

@ericholscher ericholscher Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium scary... hopefully it doesn't break anything :)

@humitos humitos marked this pull request as ready for review February 1, 2024 10:20
@humitos humitos merged commit 39134c2 into main Feb 1, 2024
@humitos humitos deleted the humitos/add-asdf-ruby branch February 1, 2024 10:29
humitos added a commit that referenced this pull request Feb 1, 2024
humitos added a commit that referenced this pull request Feb 1, 2024
humitos added a commit to readthedocs/readthedocs.org that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants