-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Build: support Ruby under build.tools
#10346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I note there are other people installing Julia as well in a pretty weird form. We should probably document how to install any tool supported by build:
commands:
- asdf plugin add <tool> <asdf plugin url>
- asdf install <tool> <version>
- asdf global <tool> <version> Users should be able to do this without our intervention. However, for those tools that require to be compiled or are heavy in network transfer, we should probably include them in our S3 cache. |
FYI, this (storing in S3) would save 379s. 89s to compile the required modules for Jekyll would remain. I’d be fine with only a recent (3.2 or 3.1 ruby) cached. |
Note to future travelers: using the If you just want to extend the build with additional steps, the following may be more appropriate: build:
jobs:
post_system_dependencies
- asdf plugin add <tool> <asdf plugin url>
- asdf install <tool> <version>
- asdf global <tool> <version> |
Backport 47cc2d4 into Ubuntu 20.04 branch. Related readthedocs/readthedocs.org#10346
* Add support for Ruby via `asdf` Related readthedocs/readthedocs.org#10346 * Update tests
* Add support for Ruby via `asdf` Backport 47cc2d4 into Ubuntu 20.04 branch. Related readthedocs/readthedocs.org#10346 * Update tests Backport 7745ce5
I added support for Ruby 3.3.x in our build images. I tested it locally and it worked fine. This work will be deployed next Tuesday, and I'd love to heard some feedback from people already using "the hacky way" 🙏🏼 Now, Ruby is available under the normal build:
tools:
ruby: "3.3" This will use a pre-compiled version of Ruby, making the builds to build faster. |
So we should try it out after Tuesday, it's not something we can try out quite yet? |
Yes, after Tuesday. It's not deployed yet. I will write something here when it's deployed, so everybody is aware. |
We just deployed this change. Ruby 3.3 is now available on Read the Docs 🎉 |
Before: Build took 408 seconds 🎉 Also, a lot simpler: build:
os: ubuntu-22.04
+
+ tools:
+ ruby: "3.3"
commands:
- - asdf plugin add ruby https://github.com/asdf-vm/asdf-ruby.git
- - asdf install ruby 3.1.2
- - asdf global ruby 3.1.2
- - gem install bundler
- - bundle config set --local deployment 'true'
- - bundle config set --local without development
- bundle install
- >
JEKYLL_ENV=production bundle exec jekyll build --destination
_readthedocs/html --baseurl $(echo -n "$READTHEDOCS_CANONICAL_URL" | cut
-d '/' -f 4-) |
@henryiii thanks for sharing your feedback! I'm happy the UX got improved with this feature 💯 |
Uh oh!
There was an error while loading. Please reload this page.
We should add support for Ruby on
build.tools
. It will be useful for doctools like Jekyll.Work required:
settings.py
to add this tool and versiontest-builds
for this use caseThe text was updated successfully, but these errors were encountered: