Skip to content

Add support for Ruby via asdf #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Add support for Ruby via asdf #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47cc2d4
Add support for Ruby via `asdf`
humitos Jan 29, 2024
7745ce5
Update tests
humitos Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Read the Docs - Environment base
FROM ubuntu:22.04
LABEL mantainer="Read the Docs <[email protected]>"
LABEL version="ubuntu-22.04-2023.03.09"
LABEL version="ubuntu-22.04-2024.01.29"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to re-build ubuntu-20.04 as well to install the Ruby plugin on asdf.

Copy link
Member

@ericholscher ericholscher Jan 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium scary... hopefully it doesn't break anything :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #201 for this.


ENV DEBIAN_FRONTEND noninteractive
ENV LANG C.UTF-8
Expand Down Expand Up @@ -112,7 +112,7 @@ USER docs
WORKDIR /home/docs

# Install asdf
RUN git clone https://github.com/asdf-vm/asdf.git ~/.asdf --depth 1 --branch v0.11.2
RUN git clone https://github.com/asdf-vm/asdf.git ~/.asdf --depth 1 --branch v0.14.0
RUN echo ". /home/docs/.asdf/asdf.sh" >> /home/docs/.bashrc
RUN echo ". /home/docs/.asdf/completions/asdf.bash" >> /home/docs/.bashrc

Expand All @@ -124,11 +124,13 @@ RUN asdf plugin add python
RUN asdf plugin add nodejs https://github.com/asdf-vm/asdf-nodejs.git
RUN asdf plugin add rust https://github.com/code-lever/asdf-rust.git
RUN asdf plugin add golang https://github.com/kennyp/asdf-golang.git
RUN asdf plugin add ruby https://github.com/asdf-vm/asdf-ruby.git

# Create directories for languages installations
RUN mkdir -p /home/docs/.asdf/installs/python && \
mkdir -p /home/docs/.asdf/installs/nodejs && \
mkdir -p /home/docs/.asdf/installs/rust && \
mkdir -p /home/docs/.asdf/installs/golang
mkdir -p /home/docs/.asdf/installs/golang && \
mkdir -p /home/docs/.asdf/installs/ruby

CMD ["/bin/bash"]
4 changes: 2 additions & 2 deletions tests/test_versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
@pytest.mark.parametrize(
'command,expected_output',
[
('asdf version', 'v0.11.2-8eb11b8'),
('asdf plugin list', '\n'.join(['golang', 'nodejs', 'python', 'rust'])),
('asdf version', 'v0.14.0-ccdd47d'),
('asdf plugin list', '\n'.join(['golang', 'nodejs', 'python', 'ruby', 'rust'])),
('git --version', 'git version 2.34.1'),
]
)
Expand Down