fix #96 gradle build #98

ouertani · 2014-08-19T06:49:26Z

No description provided.

viktorklang · 2014-08-19T13:20:38Z

build.gradle

+
+subprojects {
+  apply plugin: 'java'
+  sourceCompatibility = 1.7


Is this true?

Hint:
"javacOptions in compile ++= Seq("-encoding", "UTF-8", "-source", "1.6", "-target", "1.6", "-Xlint:unchecked", "-Xlint:deprecation")"

@viktorklang : Should we support java 6 ?

viktorklang · 2014-08-19T14:11:54Z

Regarding Java6 support, that's what we currently support and changing that would be a completely different PR IMO.

viktorklang · 2014-08-19T14:45:45Z

build.gradle

+
+    gradle.projectsEvaluated {
+        tasks.withType(JavaCompile) {
+            options.compilerArgs << "-Xlint:unchecked" << "-Xlint:deprecation"


we need encoding UTF-8 here too, right?

Yes indeed, updated on lines below.

ouertani · 2014-10-21T12:06:31Z

@reactive-streams/contributors any update ?

ouertani · 2014-10-27T11:09:35Z

build.gradle

+    apply plugin: 'idea'
+
+    group = 'org.reactivestreams'
+    version = '0.4.0'


updated to 0.4.0

viktorklang · 2014-10-27T13:38:03Z

@reactive-streams/contributors Can the contributors try this PR and verify that it works for the intents and purposes of build and publish?

ktoso · 2014-10-27T13:40:09Z

Is it possible to publish locally (ivy-style) with this build or would it need some more plugins?

// that's my use case when working on the tck and validating with akka-streams

benjchristensen · 2014-10-27T19:09:40Z

The build fails for me.

100 errors
1 warning
:reactive-streams-tck:compileJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':reactive-streams-tck:compileJava'.
> Compilation failed; see the compiler error output for details.

I also recommend you chmod +x gradlew and commit it in an executable state so on checkout a user can just invoke ./gradlew build without making it executable every time.

The branch and status for me doing the test above is:

$ git remote -v
origin  https://github.com/ouertani/reactive-streams.git (fetch)
origin  https://github.com/ouertani/reactive-streams.git (push)

$ git status
On branch gradle_build
Your branch is up-to-date with 'origin/gradle_build'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

    modified:   gradlew

no changes added to commit (use "git add" and/or "git commit -a")

ouertani · 2014-10-28T05:40:29Z

@benjchristensen build is working ouertani@f8797b8

ouertani · 2014-10-28T12:41:37Z

@ktoso

   ./gradlew install

Installs the 'archives' artifacts into the local Maven repository.

ktoso · 2014-10-28T12:45:19Z

@ouertani that's why I'm asking about local ivy2 repos. Makes things a bit easier on my side if it's possible out-of-the-box.

ouertani · 2014-10-29T05:32:19Z

@ktoso, I think the build definition should be updated as follows but IMHO don't recommend to use urls

    repositories {  
        mavenLocal()
        mavenCentral()   
        ivy { 
            artifactPattern "/opt/ivycache/local2/[organisation]/[module]/[revision]/[artifact](-[classifier])-[revision](.[ext])" 
            url '/opt/ivycache/local' 
        } 
    }
    uploadArchives {
        repositories {
            add(new org.apache.ivy.plugins.resolver.FileSystemResolver()) {
                addIvyPattern "/opt/ivycache/local2/[organisation]/[module]/[revision]/[artifact](-[classifier])-[revision](.[ext])"
                addArtifactPattern "/opt/ivycache/local/[organisation]/[module]/[revision]/[artifact](-[classifier])-[revision](.[ext])"
            }
        }

viktorklang · 2014-11-06T13:37:25Z

@ktoso @ouertani Do these links help?

http://www.gradle.org/docs/current/userguide/publishing_ivy.html
http://www.gradle.org/docs/current/dsl/org.gradle.api.artifacts.repositories.IvyArtifactRepository.html

viktorklang · 2014-11-06T13:37:46Z

Can more @reactive-streams/contributors verify that this is a solid replacement for the current build so we can either yay or nay it? Thank you

ktoso · 2014-11-06T13:40:18Z

Thanks for the links @viktorklang – that works for me then, I'm fine with whatever @reactive-streams/contributors quorum decides on this then 😉

smaldini · 2014-11-06T14:09:52Z

Need to take a moment to evaluate it, will do after some work for a customer;

viktorklang · 2014-11-06T14:13:54Z

Thanks @smaldini

viktorklang · 2014-11-08T17:37:06Z

@ouertani I think the following PR will be of importance for this PR: #136

Update: fixed PR number

ouertani · 2014-11-09T07:18:23Z

@viktorklang @ktoso I add ivy support ouertani@8a2e7f0 but noted ;

ivy {
                // change to point to your repo, e.g. http://my.org/repo
                url "${rootProject.buildDir}/repo"
}

ouertani · 2014-11-09T07:20:35Z

@viktorklang, yes example subproject should also be included. But this should be after or before merging this PR ?

viktorklang · 2014-11-09T08:52:38Z

@ouertani Absolutely, I just wanted to give you a heads up :)

ldaley · 2014-11-09T23:57:24Z

build.gradle

+    version = '0.4.0'
+
+
+    gradle.projectsEvaluated {


This projectsEvaluated wrapper should go. It's not needed.

ldaley · 2014-11-10T00:00:33Z

Looks ok to me. There are probably some cosmetic improvements that can be made though.

viktorklang · 2014-11-20T08:36:34Z

@reactive-streams/contributors My thinking is to merge this after we ship 1.0-M1 so we can try this out for publishing 1.0-RC1. Sound good? Vote?

ouertani · 2014-11-20T12:46:26Z

@viktorklang @alkemist example project has been add

viktorklang · 2014-11-20T13:03:30Z

@ouertani Excellent! Would you mind squashing the commits please?

ouertani · 2014-11-20T15:02:08Z

@viktorklang done c455d91 👍

viktorklang · 2014-11-21T17:43:08Z

build.gradle

+
+
+    group = 'org.reactivestreams'
+    version = '0.4.0'


Bump version to 1.0.0.M1

viktorklang · 2014-11-21T19:19:15Z

I'm ready to merge this after version bump of RS to 1.0.0.M1 and Gradle 2.1!

Updates CONTRIBUTING.md with Gatekeeper SLAs =tck method names and fine-details in some specs improved =tck reactive-streams#128 TCK updated to reflect merged rules 2.13 and 2.14 Moves the examples out to its own sub-project and makes sure that they are compiled but not published. =tck reactive-streams#138 clarify docs on registerOnSubscribe Aims to clarify confusion about this method, as seen in reactive-streams#138 fix reactive-streams#96 fix reactive-streams#95 gradle build tool makes gradlew executable add inter dependency add ivy publish incubator plugin but using this url "${rootProject.buildDir}/repo" merge add example project add example project

ouertani · 2014-11-22T10:20:43Z

@viktorklang updated to 2.1 and 1.0.0.M1.

viktorklang · 2014-11-22T19:25:14Z

@reactive-streams/contributors I think everyone has had ample time to vote against this one (since august 19th to be specific). Merging, and now we are on gradle iso sbt!

fix #96 gradle build

viktorklang · 2014-11-22T19:25:28Z

Thanks so much for your contribution @ouertani!

viktorklang reviewed Aug 19, 2014
View reviewed changes

ouertani force-pushed the gradle_build branch 2 times, most recently from 3e2ca6b to 1e4ff2b Compare August 20, 2014 06:13

viktorklang modified the milestone: 1.0.0-RC1 Oct 24, 2014

ouertani force-pushed the gradle_build branch from 1e4ff2b to fcfaf7f Compare October 27, 2014 11:08

ouertani reviewed Oct 27, 2014
View reviewed changes

build.gradle

apply plugin: 'idea'

group = 'org.reactivestreams'

version = '0.4.0'

Copy link

Contributor Author

ouertani Oct 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to 0.4.0

ouertani force-pushed the gradle_build branch from 30c2b95 to f8797b8 Compare October 28, 2014 05:31

ldaley reviewed Nov 9, 2014
View reviewed changes

build.gradle

version = '0.4.0'

gradle.projectsEvaluated {

Copy link

Contributor

ldaley Nov 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This projectsEvaluated wrapper should go. It's not needed.

viktorklang mentioned this pull request Nov 11, 2014

Fixed the compilation error in unicast example #135

Closed

ouertani force-pushed the gradle_build branch from 126aa5d to faf001e Compare November 20, 2014 12:39

ouertani force-pushed the gradle_build branch 2 times, most recently from b9756df to c455d91 Compare November 20, 2014 13:40

viktorklang reviewed Nov 21, 2014
View reviewed changes

build.gradle

group = 'org.reactivestreams'

version = '0.4.0'

Copy link

Contributor

viktorklang Nov 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump version to 1.0.0.M1

ouertani force-pushed the gradle_build branch from c455d91 to dddbd3a Compare November 22, 2014 10:16

viktorklang added a commit that referenced this pull request Nov 22, 2014

Merge pull request #98 from ouertani/gradle_build

91120b8

fix #96 gradle build

viktorklang merged commit 91120b8 into reactive-streams:master Nov 22, 2014

fix #96 gradle build #98

fix #96 gradle build #98

Uh oh!

Conversation

ouertani commented Aug 19, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

viktorklang commented Aug 19, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ouertani commented Oct 21, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

viktorklang commented Oct 27, 2014

Uh oh!

ktoso commented Oct 27, 2014

Uh oh!

benjchristensen commented Oct 27, 2014

Uh oh!

ouertani commented Oct 28, 2014

Uh oh!

ouertani commented Oct 28, 2014

Uh oh!

ktoso commented Oct 28, 2014

Uh oh!

ouertani commented Oct 29, 2014

Uh oh!

viktorklang commented Nov 6, 2014

Uh oh!

viktorklang commented Nov 6, 2014

Uh oh!

ktoso commented Nov 6, 2014

Uh oh!

smaldini commented Nov 6, 2014

Uh oh!

viktorklang commented Nov 6, 2014

Uh oh!

viktorklang commented Nov 8, 2014

Uh oh!

ouertani commented Nov 9, 2014

Uh oh!

ouertani commented Nov 9, 2014

Uh oh!

viktorklang commented Nov 9, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ldaley commented Nov 10, 2014

Uh oh!

viktorklang commented Nov 20, 2014

Uh oh!

ouertani commented Nov 20, 2014

Uh oh!

viktorklang commented Nov 20, 2014

Uh oh!

ouertani commented Nov 20, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

viktorklang commented Nov 21, 2014

Uh oh!

ouertani commented Nov 22, 2014

Uh oh!

viktorklang commented Nov 22, 2014

Uh oh!

viktorklang commented Nov 22, 2014

Uh oh!

Uh oh!