Skip to content

Update TCK to reflect new 2.13 #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viktorklang opened this issue Oct 24, 2014 · 7 comments · Fixed by #130
Closed

Update TCK to reflect new 2.13 #128

viktorklang opened this issue Oct 24, 2014 · 7 comments · Fixed by #130
Milestone

Comments

@viktorklang
Copy link
Contributor

2.13 and 2.14 were simplified and merged into 2.13, update the TCK to reflect this change.

@viktorklang viktorklang modified the milestone: 1.0.0-RC1 Oct 24, 2014
@viktorklang
Copy link
Contributor Author

@ktoso Can you have a look at this at your convenience?

@ktoso
Copy link
Contributor

ktoso commented Oct 28, 2014

Sure, I think I'll be able to squeeze it in tomorrow mid-day!

@viktorklang
Copy link
Contributor Author

@ktoso Fantastic. If you have time, do a quick run-thru of the spec vs the TCK to see if there's anything that needs to be addressed before RC1

@ktoso
Copy link
Contributor

ktoso commented Oct 28, 2014

That wasn't too much work actually //cc @viktorklang #130 ;)

I'll have a look at the other rules now, if they match still. If I don't open tickets assume I didn't find anything wrong with the other tests and their matching rules.

@viktorklang
Copy link
Contributor Author

Sounds great. Thank you
On Oct 28, 2014 11:16 AM, "Konrad Malawski" [email protected]
wrote:

That wasn't too much work actually //cc @viktorklang
https://github.com/viktorklang #130
#130 ;)

I'll have a look at the other rules now, if they match still. If I don't
open tickets assume I didn't find anything wrong with the other tests and
their matching rules.


Reply to this email directly or view it on GitHub
#128 (comment)
.

@ktoso
Copy link
Contributor

ktoso commented Oct 28, 2014

@viktorklang I think we're mostly good. I changed some minor things and one mutable -> final change which may have caused test failures I believe, see more: #131

@viktorklang
Copy link
Contributor Author

@ktoso Cool, I'll have a look

viktorklang added a commit that referenced this issue Nov 6, 2014
=tck #128 TCK updated to reflect merged rules 2.13 and 2.14
ouertani added a commit to ouertani/reactive-streams that referenced this issue Nov 20, 2014
Updates CONTRIBUTING.md with Gatekeeper SLAs

=tck method names and fine-details in some specs improved

=tck reactive-streams#128 TCK updated to reflect merged rules 2.13 and 2.14

Moves the examples out to its own sub-project and makes sure that they are compiled but not published.

=tck reactive-streams#138 clarify docs on registerOnSubscribe

Aims to clarify confusion about this method, as seen in reactive-streams#138

fix reactive-streams#96

fix reactive-streams#95 gradle build tool

makes gradlew executable

 add inter dependency

add ivy publish incubator plugin  but using this url "${rootProject.buildDir}/repo"

 merge

add example project
ouertani added a commit to ouertani/reactive-streams that referenced this issue Nov 20, 2014
Updates CONTRIBUTING.md with Gatekeeper SLAs

=tck method names and fine-details in some specs improved

=tck reactive-streams#128 TCK updated to reflect merged rules 2.13 and 2.14

Moves the examples out to its own sub-project and makes sure that they are compiled but not published.

=tck reactive-streams#138 clarify docs on registerOnSubscribe

Aims to clarify confusion about this method, as seen in reactive-streams#138

fix reactive-streams#96

fix reactive-streams#95 gradle build tool

makes gradlew executable

 add inter dependency

add ivy publish incubator plugin  but using this url "${rootProject.buildDir}/repo"

 merge

add example project

add example project
ouertani added a commit to ouertani/reactive-streams that referenced this issue Nov 22, 2014
Updates CONTRIBUTING.md with Gatekeeper SLAs

=tck method names and fine-details in some specs improved

=tck reactive-streams#128 TCK updated to reflect merged rules 2.13 and 2.14

Moves the examples out to its own sub-project and makes sure that they are compiled but not published.

=tck reactive-streams#138 clarify docs on registerOnSubscribe

Aims to clarify confusion about this method, as seen in reactive-streams#138

fix reactive-streams#96

fix reactive-streams#95 gradle build tool

makes gradlew executable

 add inter dependency

add ivy publish incubator plugin  but using this url "${rootProject.buildDir}/repo"

 merge

add example project

add example project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants