Skip to content

Replace build.sbt #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ouertani opened this issue Aug 18, 2014 · 7 comments
Closed

Replace build.sbt #95

ouertani opened this issue Aug 18, 2014 · 7 comments
Labels
enhancement wip
Milestone
1.0.0-RC1

Comments

@ouertani
Copy link
Contributor

Source files have been translated from Scala to Java ones but the build tool remains related to scala sbt.

I propose to change and use the old maven build tool.
ouertani added a commit to ouertani/reactive-streams that referenced this issue Aug 18, 2014
@ouertani
fix reactive-streams#95
aa67056
@viktorklang
Copy link
Contributor

See #34

I think the top choice back then was Gradle.

@ouertani
Copy link
Contributor Author

@viktorklang I vote upon maven as it is the default build tool for java project. Despite, Gradle start to be adopted by many projects as it is more simple and powerful, Maven still the direct choice and this case.

note : sbt propose mavenization using makePom cmd

@viktorklang
Copy link
Contributor

Default build tool for Java?

@ouertani
Copy link
Contributor Author

I mean straightforward or direct choice.

@viktorklang
Copy link
Contributor

Given that there are very few expected to build this project (implementations and users would depend on the published artifacts), I am confident we can go with the contributor vote winner of Gradle.

(My multi-year experience of Maven is that it is the next-worst build tool after Ant.)

ouertani added a commit to ouertani/reactive-streams that referenced this issue Aug 19, 2014
@ouertani
fix reactive-streams#95 gradle_build
b81a9e6
ouertani added a commit to ouertani/reactive-streams that referenced this issue Aug 19, 2014
@ouertani
fix reactive-streams#95 gradle_build
892a441
ouertani added a commit to ouertani/reactive-streams that referenced this issue Aug 19, 2014
@ouertani
fix reactive-streams#95 gradle_build
f009ab0
@ouertani
Copy link
Contributor Author

@viktorklang 💯 agree that Gradle is better and powerful 👍 then Maven. But since we build an api and not library or a framework, old maven could be the right choice.
Think about Vert.x : version 3 is moving from Gradle to Maven : discussion

@viktorklang
Copy link
Contributor

I know I'm repeating myself but the reactive streams project -should not-
be built by a user. There is no (to me apparent) need to. Users may use
whatever buildtool they like and depend on the published RS artifacts.

(Right now sbt works and there's much more important work to be done, so
spending time switching build tool needs justification, see the Issue I
linked to earlier where Gradle was the consensus but we decided to hold off
switching until 1.0-ish)

PS. You are able to configure any build tool to build Reactive Streams with
but I don't see why that should need to leak into the RS repo.
On Aug 19, 2014 9:17 AM, "slim" [email protected] wrote:

@viktorklang https://github.com/viktorklang [image: 💯] agree that
Gradle is better and powerful [image: 👍] then Maven. But since we
build an api and not library or a framework, old maven could be the right
choice.
Think about Vert.x : version 3 is moving from Gradle to Maven : discussion
https://groups.google.com/forum/#!searchin/vertx/vert.x%24203.0/vertx/DHL9cAg4SYo/FAqi1iBimOwJ

—
Reply to this email directly or view it on GitHub
#95 (comment)
.

ouertani added a commit to ouertani/reactive-streams that referenced this issue Aug 19, 2014
@ouertani
fix reactive-streams#95 gradle build tool
6f9af94
ouertani added a commit to ouertani/reactive-streams that referenced this issue Aug 20, 2014
@ouertani
fix reactive-streams#95 gradle build tool
3e2ca6b
ouertani added a commit to ouertani/reactive-streams that referenced this issue Aug 20, 2014
@ouertani
fix reactive-streams#95 gradle build tool
1e4ff2b
@viktorklang viktorklang modified the milestone: 1.0.0-RC1 Oct 24, 2014
ouertani added a commit to ouertani/reactive-streams that referenced this issue Oct 27, 2014
@ouertani
fix reactive-streams#95 gradle build tool
fcfaf7f
ouertani added a commit to ouertani/reactive-streams that referenced this issue Oct 27, 2014
@ouertani
fix reactive-streams#95 gradle build tool
2547d35
ouertani added a commit to ouertani/reactive-streams that referenced this issue Oct 27, 2014
@ouertani
Merge branch 'gradle_build' of https://github.com/ouertani/reactive-s…
30c2b95 
…treams into gradle_build, fix reactive-streams#95
ouertani added a commit to ouertani/reactive-streams that referenced this issue Oct 28, 2014
@ouertani
fix reactive-streams#95 gradle build tool
de48544
ouertani added a commit to ouertani/reactive-streams that referenced this issue Nov 9, 2014
@ouertani
Merge branch 'gradle_build' of https://github.com/ouertani/reactive-s…
d98a7a1 
…treams into gradle_build reactive-streams#95
ouertani added a commit to ouertani/reactive-streams that referenced this issue Nov 10, 2014
@ouertani
update gradle build reactive-streams#95
7a39725
ouertani added a commit to ouertani/reactive-streams that referenced this issue Nov 20, 2014
@ouertani
fix reactive-streams#96
7313f46 
fix reactive-streams#95 gradle build tool

makes gradlew executable

 add inter dependency

add ivy publish incubator plugin  but using this url "${rootProject.buildDir}/repo"

 merge
ouertani added a commit to ouertani/reactive-streams that referenced this issue Nov 20, 2014
@ouertani
fix reactive-streams#96
7faa2ca 
Updates CONTRIBUTING.md with Gatekeeper SLAs

=tck method names and fine-details in some specs improved

=tck reactive-streams#128 TCK updated to reflect merged rules 2.13 and 2.14

Moves the examples out to its own sub-project and makes sure that they are compiled but not published.

=tck reactive-streams#138 clarify docs on registerOnSubscribe

Aims to clarify confusion about this method, as seen in reactive-streams#138

fix reactive-streams#96

fix reactive-streams#95 gradle build tool

makes gradlew executable

 add inter dependency

add ivy publish incubator plugin  but using this url "${rootProject.buildDir}/repo"

 merge

add example project
ouertani added a commit to ouertani/reactive-streams that referenced this issue Nov 20, 2014
@ouertani
fix reactive-streams#96
c455d91 
Updates CONTRIBUTING.md with Gatekeeper SLAs

=tck method names and fine-details in some specs improved

=tck reactive-streams#128 TCK updated to reflect merged rules 2.13 and 2.14

Moves the examples out to its own sub-project and makes sure that they are compiled but not published.

=tck reactive-streams#138 clarify docs on registerOnSubscribe

Aims to clarify confusion about this method, as seen in reactive-streams#138

fix reactive-streams#96

fix reactive-streams#95 gradle build tool

makes gradlew executable

 add inter dependency

add ivy publish incubator plugin  but using this url "${rootProject.buildDir}/repo"

 merge

add example project

add example project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement wip
Projects
None yet
Milestone
1.0.0-RC1
Development

No branches or pull requests
2 participants
@viktorklang @ouertani