update theme #6296
Merged
update theme #6296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canyon289
approved these changes
Nov 13, 2022
|
It should build and 1) look the same + 2) have the same functionality. We have the check the preview very carefully for this PR |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6296 +/- ##
==========================================
+ Coverage 94.12% 94.17% +0.05%
==========================================
Files 111 111
Lines 23861 23913 +52
==========================================
+ Hits 22458 22520 +62
+ Misses 1403 1393 -10
|
|
Only yhe edit this page button seems to not be working. I'll take a look tomorrow |
OriolAbril
commented
Nov 15, 2022
|
|
||
|
|
||
| # Theme options are theme-specific and customize the look and feel of a theme | ||
| # further. For a list of options available for each theme, see the | ||
| # documentation. | ||
|
|
||
| html_theme_options = { | ||
| "icon_links": [ |
There was a problem hiding this comment.
@twiecki answering pymc-devs/pymc-examples#465 (comment) here. If you look at the preview you will see that the logos are still there. What is being removed is the triplication of this info. Now this is part of the pymc-sphinx-theme which inherits from pydata-sphinx-theme and sets up most of the common elements between al 3 main websittes (and others like pymc-experimental or pymc-bart)
twiecki
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am switching the pydata-sphinx-theme to pymc-sphinx-theme.
It is a very thin wrapper over the pydata-sphinx-theme to abstract the common
logic between the 3 websites, so we don't need to make changes to the 3
repos every time we want to update something or something breaks.
Checklist
Docs / Maintenance