Skip to content

update theme #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 16, 2022
Merged

update theme #465

merged 3 commits into from
Nov 16, 2022

Conversation

OriolAbril
Copy link
Member

3rd theme update PR, see pymc-devs/pymc#6296 for more details

@drbenvincent
Copy link
Contributor

Hi @OriolAbril. So I've been learning a bit more about sphinx, but there's so much to it that I'm obviously not a master yet! Do you just need an approval for this? The built docs look fine with no problems.

html_theme_options = {
"icon_links": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing these?

Copy link
Member Author

@OriolAbril OriolAbril Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OriolAbril OriolAbril mentioned this pull request Nov 15, 2022
4 tasks
@OriolAbril
Copy link
Member Author

OriolAbril commented Nov 15, 2022

@drbenvincent I would like some help double checking everything looks and works the same, that all links are working, things like that. After that leave a review with comments or aproval

@twiecki
Copy link
Member

twiecki commented Nov 15, 2022

Where can we view it?

@OriolAbril
Copy link
Member Author

Where can we view it?

Yes, alll 3 repos have a readthedocs "check", if you click on the "details" there you'll see the preview. For this PR the "details" link goes to https://pymcio--465.org.readthedocs.build/projects/examples/en/465/gallery.html

@twiecki
Copy link
Member

twiecki commented Nov 15, 2022

image

the outside link box is back

@OriolAbril
Copy link
Member Author

Everything should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants