Skip to content

Navbar is broken #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
twiecki opened this issue Oct 27, 2022 · 4 comments · Fixed by #55
Closed

Navbar is broken #53

twiecki opened this issue Oct 27, 2022 · 4 comments · Fixed by #55

Comments

@twiecki
Copy link
Member

twiecki commented Oct 27, 2022

Not sure if this is the right repo, but if I go to:
https://www.pymc.io/projects/docs/en/latest/contributing/index.html

From there, all links in the navbar are broken, e.g. Home links to:
https://www.pymc.io/projects/docs/en/latest/https:/www.pymc.io/welcome.html.html

@cluhmann
Copy link
Member

@OriolAbril said:

We should pin the theme back to 0.10.0 and open an issue on pydata sphinx theme
Also maybe pin the theme version and update it manually as it is quite unstable and every release has broken something so far

and said that this is what we are running into and that:

it has an open PR already to fix the issue but I don't know how long it will take to merge and to have a new release. We should probably pin back to <0.10.0 in the meantime so the navbar works. Can someone do it?

@cluhmann cluhmann changed the title Navbar from Contributing is broken Navbar is broken Nov 12, 2022
@cluhmann
Copy link
Member

cluhmann commented Nov 12, 2022

That PR has been merged and is now sitting in version 0.12.0rc1 of the theme, FYI.

@reshamas
Copy link
Contributor

@symeneses
For reference, here is a past PR where there was some pinning of the theme (Sep 2011):
pymc-devs/pymc#6120

@OriolAbril
Copy link
Member

pymc-devs/pymc#6296, pymc-devs/pymc-examples#465, #57 are fixing the issue for good and removing the need for 3 PRs whenever we do any theme related change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants