Edit mocks #4708
Merged
Edit mocks #4708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
commented
Mar 30, 2020
| @@ -1256,7 +1256,6 @@ | |||
| "size": 12, | |||
| "color": "grey" | |||
| }, | |||
| "showlegend": true, | |||
There was a problem hiding this comment.
First set to true here!
There was a problem hiding this comment.
But then set to false few lines below.
There was a problem hiding this comment.
I'm surprised that's even legal JSON!
| @@ -28,6 +28,6 @@ | |||
| "height":400, | |||
| "width":400, | |||
| "barmode":"group", | |||
| "barnorm":false | |||
| "barnorm":"" | |||
There was a problem hiding this comment.
Or just 🔪 since blank is the default. Not blocking though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit f065405 fixes #4705.
Commit f9bff4d removes duplicate keys from two other mocks.
@plotly/plotly_js