Skip to content

Edit mocks #4708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Edit mocks #4708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f065405
edit mocks - false is not a valid barmode
archmoj Mar 29, 2020
f9bff4d
remove duplicate keys from two mocks
archmoj Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/image/mocks/8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1256,7 +1256,6 @@
"size": 12,
"color": "grey"
},
"showlegend": true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First set to true here!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then set to false few lines below.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that's even legal JSON!

"width": 500,
"height": 500,
"margin": {
Expand Down
2 changes: 1 addition & 1 deletion test/image/mocks/bar_attrs_group.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@
"height":400,
"width":400,
"barmode":"group",
"barnorm":false
"barnorm":""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just 🔪 since blank is the default. Not blocking though.

}
}
2 changes: 1 addition & 1 deletion test/image/mocks/bar_attrs_overlay.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@
"height":400,
"width":400,
"barmode":"overlay",
"barnorm":false
"barnorm":""
}
}
2 changes: 1 addition & 1 deletion test/image/mocks/bar_attrs_relative.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@
"height":400,
"width":400,
"barmode":"relative",
"barnorm":false
"barnorm":""
}
}
1 change: 0 additions & 1 deletion test/image/mocks/matching-missing-axes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
"alignmentgroup": "True",
"offsetgroup": "smoker=No",
"legendgroup": "smoker=No",
"showlegend": false,
"marker": { "color": "#636efa" },
"x": [ "Male", "Female", "Male" ],
"y": [ 22.49, 22.75, 12.46 ],
Expand Down