Skip to content

Test mock bar_attrs_relative.json with unexpected "barnorm" value #4710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hmf opened this issue Mar 30, 2020 · 3 comments
Closed

Test mock bar_attrs_relative.json with unexpected "barnorm" value #4710

hmf opened this issue Mar 30, 2020 · 3 comments

Comments

@hmf
Copy link

hmf commented Mar 30, 2020

This may be the same issue described in this #4704
Mock is bar_attrs_relative.json
For reference here is the snippet:

    "layout":{
        "xaxis": {"showgrid":true},
        "yaxis": {"range":[-6,6]},
        "height":400,
        "width":400,
        "barmode":"relative",
        "barnorm":false
    }
@alexcjohnson
Copy link
Collaborator

Solved already by @archmoj in #4708 - thanks for bringing this up in #4704 🎉

@hmf
Copy link
Author

hmf commented Mar 30, 2020

@alexcjohnson Small note: The change you referre to is for the file test/image/mocks/bar_attrs_group.json. This is another bar_attrs_relative.json. Don't know if you realized that or if the change was made to all files.

@alexcjohnson
Copy link
Collaborator

bar_attrs_relative.json is included in that PR https://github.com/plotly/plotly.js/pull/4708/files#diff-d04eaf77addda33da276b8baa5db23b8 - the link you posted now says:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants