-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Drop node4 for devs + a few more dep updates #2923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- ... and its friends - note that browserity@16 use node events@2
- 🔪 color-rgba from package dep, it's only third-party, not used in src/
@@ -34,7 +34,7 @@ var matchers = { | |||
var i; | |||
if(Array.isArray(x)) { | |||
for(i = 0; i < x.length; i++) { | |||
x[i] = x[i]; | |||
if(x[i] === undefined) x[i] = undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might look weird but we need this to make eslint@5
and npm run test-jasmine -- lib
pass.
Ricky wrote:
plotly.js/test/jasmine/assets/custom_matchers.js
Lines 23 to 46 in 8517907
// toEqual except with sparse arrays populated. This arises because: | |
// | |
// var x = new Array(2) | |
// expect(x).toEqual([undefined, undefined]) | |
// | |
// will fail assertion even though x[0] === undefined and x[1] === undefined. | |
// This is because the array elements don't exist until assigned. Of course it | |
// only fails on *some* platforms (old firefox, looking at you), which is why | |
// this is worth all the footwork. | |
toLooseDeepEqual: function() { | |
function populateUndefinedArrayEls(x) { | |
var i; | |
if(Array.isArray(x)) { | |
for(i = 0; i < x.length; i++) { | |
if(x[i] === undefined) x[i] = undefined; | |
} | |
} else if(isPlainObject(x)) { | |
var keys = Object.keys(x); | |
for(i = 0; i < keys.length; i++) { | |
populateUndefinedArrayEls(x[keys[i]]); | |
} | |
} | |
return x; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WOTW (wat of the week)
@@ -61,8 +61,7 @@ | |||
"alpha-shape": "^1.0.0", | |||
"array-range": "^1.0.1", | |||
"canvas-fit": "^1.5.0", | |||
"color-normalize": "^1.0.3", | |||
"color-rgba": "^2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the story with color-rgba
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nvm I see your commit message
it's only third-party, not used in src/
👍
Keepin' up with the Joneses. 💃 |
Big bump-dep PR where
karma
gets a major bump (as promised to @alexcjohnson yesterday )eslint
gets a major bump (and one small patch to complete the migration)browserify
gets a major bumpglslify
gets bumpedcolor-normalize
version is harmonized between oursrc/
and our deps to as pointed out in Fix regl-scatter2d for IE #2863 (comment)