Skip to content

Drop node4 for devs + a few more dep updates #2923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 17, 2018
Merged

Drop node4 for devs + a few more dep updates #2923

merged 9 commits into from
Aug 17, 2018

Conversation

etpinard
Copy link
Contributor

Big bump-dep PR where

  • karma gets a major bump (as promised to @alexcjohnson yesterday )
  • eslint gets a major bump (and one small patch to complete the migration)
  • browserify gets a major bump
  • glslify gets bumped
  • the color-normalize version is harmonized between our src/ and our deps to as pointed out in Fix regl-scatter2d for IE #2863 (comment)
  • a few other uneventful version bumps

@@ -34,7 +34,7 @@ var matchers = {
var i;
if(Array.isArray(x)) {
for(i = 0; i < x.length; i++) {
x[i] = x[i];
if(x[i] === undefined) x[i] = undefined;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might look weird but we need this to make eslint@5 and npm run test-jasmine -- lib pass.

Ricky wrote:

// toEqual except with sparse arrays populated. This arises because:
//
// var x = new Array(2)
// expect(x).toEqual([undefined, undefined])
//
// will fail assertion even though x[0] === undefined and x[1] === undefined.
// This is because the array elements don't exist until assigned. Of course it
// only fails on *some* platforms (old firefox, looking at you), which is why
// this is worth all the footwork.
toLooseDeepEqual: function() {
function populateUndefinedArrayEls(x) {
var i;
if(Array.isArray(x)) {
for(i = 0; i < x.length; i++) {
if(x[i] === undefined) x[i] = undefined;
}
} else if(isPlainObject(x)) {
var keys = Object.keys(x);
for(i = 0; i < keys.length; i++) {
populateUndefinedArrayEls(x[keys[i]]);
}
}
return x;
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOTW (wat of the week)

@@ -61,8 +61,7 @@
"alpha-shape": "^1.0.0",
"array-range": "^1.0.1",
"canvas-fit": "^1.5.0",
"color-normalize": "^1.0.3",
"color-rgba": "^2.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the story with color-rgba?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nvm I see your commit message
it's only third-party, not used in src/ 👍

@alexcjohnson
Copy link
Collaborator

Keepin' up with the Joneses. 💃

@etpinard etpinard merged commit bd58230 into master Aug 17, 2018
@etpinard etpinard deleted the drop-node4 branch August 17, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants