-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Drop node4 for devs + a few more dep updates #2923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a45fc17
drop Node v4 support for dev things
etpinard 0c7e4bd
bump eslint to 5.3.0
etpinard 8517907
adapt code for eslint@5
etpinard 1f2fe94
bump karma to 3.0.0
etpinard eaa6f56
bump gzip-size to 5.0.0 (dropping node v4)
etpinard 393588e
bump browserify to v16
etpinard 6c80468
bump misc dev deps
etpinard 58ea394
bump glslify to 6.2.1
etpinard 0a4c43b
use same color-normalize version throughout src and deps
etpinard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might look weird but we need this to make
eslint@5
andnpm run test-jasmine -- lib
pass.Ricky wrote:
plotly.js/test/jasmine/assets/custom_matchers.js
Lines 23 to 46 in 8517907
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WOTW (wat of the week)