Fix regl-scatter2d for IE #2863
Conversation
|
🎉 DIMA IS BACK 🎉 |
|
🙇♂️ sorry for being off for that long. So many juicy things for plotly to accomplish. |
|
no problem @dy ! |
|
Just curious @dy , what versions of |
|
Mine is 6.1.0, yes, that may be the culprit. Should we bump it to the latest 6.2.0? |
|
Ok thanks @dy, good to know. Before bumping we would have to check it there's a CircleCI container that runs npm 6.2.0. We should run the same npm version locally and on CI. As Node 10 ships with npm6 and becomes LTS in October, I'd vote sticking to npm5 until then. I can re-generate the package-lock, if you prefer working with npm6 |
|
Thanks! I can downgrade it for the time too. |
|
The relevant regl-scatter2d commit is -> gl-vis/regl-scatter2d@30d3874 |
| @@ -41,7 +41,7 @@ | |||
| "resolved": "https://registry.npmjs.org/@etpinard/gl-text/-/gl-text-1.1.6.tgz", | |||
| "integrity": "sha512-sN007FwlqdSKJt2/cnGZu3jsAN7G4R/wxk/D6ZivPuQtrwJ42B68iuAqysJPgFepUTAsDRtGAOd1U7tZxfDJwA==", | |||
| "requires": { | |||
| "color-normalize": "1.1.0", | |||
| "color-normalize": "1.3.0", | |||
There was a problem hiding this comment.
@dy I just noticed that we're using multiple versions of color-normalize in our bundle:
There was a problem hiding this comment.
Can regl-error2d, regl-line2d and regl-scatter2d use [email protected]?
| @@ -100,10 +100,10 @@ | |||
| "ndarray-ops": "^1.2.2", | |||
| "point-cluster": "^3.1.4", | |||
| "polybooljs": "^1.2.0", | |||
| "regl": "^1.3.6", | |||
| "regl": "^1.3.7", | |||
There was a problem hiding this comment.
only this regl-project/regl#496 is new in 1.3.7 which only affects logging styles which should not have any effects for plotly.js
| "gl-streamtube3d": "^1.0.0", | ||
| "@etpinard/gl-text": "^1.1.6", |
There was a problem hiding this comment.
@dy is it ok to use gl-text now?
|
@dy so are all The
but it does spit out
in the console on browserstack. |
|
Yes, I noticed that error. That seems to be regl init error, needs investigation. |
|
Any updates of this @dy?. Would be nice to get this in |
|
ping @dy - any updates? |
|
@alexcjohnson I'd vote for merging this thing for 1.40.0 even though #2863 (comment) didn't get addressed yet. Marker symbols in IE11 and Edge appear fixed, or at least they're a lot better than before. #2802 would remain open for the time being. |
|
As long as those console errors don't break other pre-existing functionality then sure, lets merge. 💃 |
|
Oops. Looks this PR didn't fix things in Edge:
|
This fixes #2802.