use UTC milliseconds for internal representation of dates #1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove commented out code about 3d pie chart attributes
fix annotation category positioning
- so that zoomed ranges are computed consistently for all axis types
- so that date axis ranges can be tested with some tolerance
* Fixed incorrect bar size in the hover labels of stacked bars. Fixes #1157
Fix hover label in stacked bars
- looks like the CI machine has less precision than my laptop
Modebar date zoom fix
tasks: fixup main bundle URLs
We still interpret JS date objects according to the date and hour they have in the local timezone, and for backward compatibility we shift milliseconds (in ranges etc) by the local/UTC offset.
alexcjohnson
commented
Nov 19, 2016
| @@ -489,7 +489,7 @@ describe('Test shapes', function() { | |||
| title: 'linked to date and category axes', | |||
| xaxis: { | |||
| type: 'date', | |||
| range: ['2000-01-01', (new Date(2000, 1, 2)).getTime()] | |||
There was a problem hiding this comment.
this old format for date axis range was mucking up the test code but not affecting the code being tested (because that's all after supplyDefaults cleans these) so it was useless.
Add check for failed binding comparison
Fix defs.metaKeys field
- allow , and spaces in middle of numeric strings
- and allow only ' ' in middle instead of all space characters
and test calc of uniform AND nonuniform bins
fix regression in lib/clean_number (alternate)
Fix date histograms
make sure it's not already HH:MM
tickvals / ticktext edge cases
|
ugh, this didn't like separately merging master vs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@etpinard this builds on the ISO-8601 PR #1158 so note the base branch but we can merge directly to master if #1158 goes in first.
Changes our internal date linearization to use UTC rather than local milliseconds. Every day on a Plotly graph will now be 24 hours long, with no daylight shifts.
Note that for backward compatibility I still have us treat millisecond values (in ranges etc) as they were calculated previously, in local time, and shift them to UTC. I do the same thing with js date objects, on the theory that users generally construct these by using
new Date(y, m, d, H, M, S, ms)with the date/time components they expect to see on the final graph.If and when we add support for explicit timezone settings, we can do smarter things for users who specify a timezone, but I think this should remain the default behavior.
Fixes #171 and #811