Skip to content

Dropdown selects the wrong option #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rreusser opened this issue Nov 18, 2016 · 3 comments
Closed

Dropdown selects the wrong option #1169

rreusser opened this issue Nov 18, 2016 · 3 comments
Assignees
@rreusser
Labels
bug something broken

Comments

@rreusser
Copy link
Contributor

Select option b. It jumps to option c:

http://codepen.io/rsreusser/pen/YpNGaY?editors=0010

cc @jackparmer @etpinard
@rreusser rreusser added the bug something broken label Nov 18, 2016
@n-riesco
Copy link
Contributor

I'm already looking at adding a scrollbar to the dropdown menu. I could have a look at this issue too.

n-riesco added a commit to n-riesco/plotly.js that referenced this issue Nov 18, 2016
@n-riesco
updatemenus: fix wrong header update
5a7d494 
* Note that the click handler already updates the header and invokes
  `Plots.executeAPICommand`.

Fixes plotly#1169
@n-riesco n-riesco mentioned this issue Nov 18, 2016
Closed
@rreusser rreusser self-assigned this Nov 21, 2016
@rreusser
Copy link
Contributor Author

rreusser commented Nov 21, 2016 •
edited
Loading

Investigating this. @n-riesco's assessment is that my matching logic is interfering and needs to be better, which seems correct. Adding failing test and fixing now.

@rreusser rreusser mentioned this issue Nov 21, 2016
Merged
etpinard added a commit that referenced this issue Nov 21, 2016
@etpinard
test: add jasmine test for #1169
62c95f8
n-riesco added a commit to n-riesco/plotly.js that referenced this issue Nov 21, 2016
@n-riesco
command: improve detection of changes in traces
4f3176c 
* Added lookup table to search commands by value.

Fixes plotly#1169
n-riesco added a commit to n-riesco/plotly.js that referenced this issue Nov 21, 2016
@n-riesco
command: improve detection of changes in traces
cb8846a 
* Added lookup table to search commands by value.

Fixes plotly#1169
@n-riesco n-riesco mentioned this issue Nov 21, 2016
Open
@etpinard
Copy link
Contributor

Closed in #1176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rreusser rreusser

Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rreusser @n-riesco @etpinard