-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
use UTC milliseconds for internal representation of dates #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
e5916c4
update changelog for 1.20.0
etpinard d48c310
1.20.0
etpinard fcd9547
remove commented out code about 3d pie chart attributes
alexcjohnson e94b1d1
Merge pull request #1152 from plotly/no-3d-pies
alexcjohnson 9583cfa
annotation: assign dflt pos if category IS NOT present
etpinard 6e7d5d6
test: add annotations to mock 16
etpinard 58b91e7
test: add annotation with category positions case
etpinard ca2e112
Merge pull request #1155 from plotly/annotation-category-fix
etpinard 2204914
update changelog for 1.20.1
etpinard 564f661
1.20.1
etpinard d7de2ae
issue #1160 fix
adamborowski 665e56c
modebar: use axis r21 and l2r to compute zoom +/- ranges
etpinard 8e9d458
test: test all cartesian axis types in modebar click cases
etpinard c45338d
test: use ax.r2l to assert range
etpinard 8472254
bar: fix wrong bar size in hover labels
n-riesco 1c32bc5
Merge pull request #1163 from n-riesco/pr-20161117-fix-issue-1157
etpinard f1b686f
test: assert up to yyyy-mm-dd for date ranges
etpinard 4d9b02d
Merge pull request #1162 from plotly/modebar-date-zoom-fix
etpinard 9e71209
update changelog for 1.20.2
etpinard 775682f
1.20.2
etpinard 6cf4283
tasks: fixup main bundle URLs
etpinard 5971c16
Merge pull request #1166 from plotly/stats-fixup
etpinard fb44aee
fixing the non-fancy scattergl 'single data point' infinite loop
monfera bd34ec2
use UTC milliseconds for internal representation of dates
alexcjohnson 9c645e7
if it works in Alaska it'll work anywhere.
alexcjohnson 6d83c7b
verify our test environment has DST
alexcjohnson 02e98a9
fix range selectors for UTC, and tests to run in arbitrary timezone
alexcjohnson c41a0b4
lint
alexcjohnson 94f4d5f
test case for scattergl single data point
monfera fb0ff70
Merge pull request #1168 from monfera/scattergl-with-one-datapoint
etpinard 1058366
Clone input trace
dy ea8ce86
Ignore line ending style
dy fa18648
Fix typo
dy ecd795a
test: add case for addTraces with exising data/traces
etpinard 7e4c5c1
lint
etpinard 6d2f655
Add check for failed binding comparison
rreusser 6dc01d6
Make 'is simple binding' false for non-length-one arrays
rreusser 125770b
Merge pull request #1175 from plotly/pr1136-clone-trace
etpinard 242f3b4
Add test for non-present command arg value
rreusser 218744d
Fix command api test that doesn't actually test anything
rreusser 62c95f8
test: add jasmine test for #1169
etpinard 63f455d
Merge pull request #1176 from plotly/fix-command-api-bug
etpinard a23a460
update changelog for 1.20.3
etpinard d9caee9
1.20.3
etpinard 744041b
schema: fix defs.metaKeys field
etpinard bfba27d
Merge pull request #1182 from plotly/schema-metakey-fix
etpinard 318fc48
update changelog for 1.20.4
etpinard 48b0358
1.20.4
etpinard 5f98edd
fix regression in lib/clean_number (alternate)
etpinard 79fe7d5
turn front/end/global regex's into 1
etpinard b4da924
fix for date histograms with uniform bins
alexcjohnson 2a57525
temp fix for histogram2d test in UTC environment
alexcjohnson 846f2c7
Merge pull request #1185 from plotly/clean-datum-regression-alt
etpinard c130932
Merge pull request #1186 from plotly/fix-date-histograms
alexcjohnson 426077a
handle and test a bunch of tickvals / ticktext edge cases
alexcjohnson 27fb4b1
tighter test for when to remove seconds from date tick text
alexcjohnson 74da7a4
include test that we didn't add any categories to category tickvals test
alexcjohnson 77f745e
fix log axes tickvals default text formatting bug
alexcjohnson 6762130
remove old (buggy) hovertext cruft, clean up and test edge cases
alexcjohnson c70f04a
suffix -> dateHead / headPart
alexcjohnson bd24421
Merge pull request #1191 from plotly/tickvals-edge-cases
alexcjohnson f35313a
update changelog for 1.20.5
etpinard 0fc37d6
1.20.5
etpinard cd73020
Merge branch 'master' into dates-utc-backend
alexcjohnson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this old format for date axis range was mucking up the test code but not affecting the code being tested (because that's all after supplyDefaults cleans these) so it was useless.