Add stat_ecdf support #2052
Closed
Add stat_ecdf support #2052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
reviewed
Nov 1, 2021
R/layers2traces.R
Outdated
Comment on lines
626
to
627
| to_basic.default<- function(data, prestats_data, layout, params, p, ...) { | ||
|
|
There was a problem hiding this comment.
Suggested change
| to_basic.default<- function(data, prestats_data, layout, params, p, ...) { | |
| to_basic.default <- function(data, prestats_data, layout, params, p, ...) { |
cpsievert
reviewed
Nov 1, 2021
R/layers2traces.R
Outdated
| @@ -252,7 +252,7 @@ to_basic.GeomLine <- function(data, prestats_data, layout, params, p, ...) { | |||
|
|
|||
| #' @export | |||
| to_basic.GeomStep <- function(data, prestats_data, layout, params, p, ...) { | |||
| prefix_class(data, "GeomPath") | |||
| prefix_class(if((params$direction %||% "vh") %in% c("vh", "hv", "mid")) ggplot2:::stairstep(data, direction = params$direction) else data, c("GeomPath", "GeomStep")) | |||
There was a problem hiding this comment.
Using ::: isn't allowed by R CMD check. Use ggfun() instead
There was a problem hiding this comment.
For some reason this breaks default geom_step() usage. See, for example, the change in tests/testthat/_snaps/ggplot-step/step-gg-hv.svg
There was a problem hiding this comment.
I think I fixed the test issues. basically just re rendering the svg solved it
There was a problem hiding this comment.
No, the tests are still broken. I don't think this is the right fix.
|
This isn't the right approach, I'll take this on in #2065 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEWS.md