Skip to content

Add stat_ecdf support #2052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@

* `ggplotly()` does not issue warnings with `options(warnPartialMatchArgs = TRUE)` any longer. (#2046, @bersbersbers)

## BUG fixes

* `stat_ecdf()` now gives the correct output. (#2052)


# 4.10.0

## Breaking changes in JavaScript API
Expand Down
2 changes: 1 addition & 1 deletion R/layers2traces.R
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ to_basic.GeomLine <- function(data, prestats_data, layout, params, p, ...) {

#' @export
to_basic.GeomStep <- function(data, prestats_data, layout, params, p, ...) {
prefix_class(data, "GeomPath")
prefix_class(if((params$direction %||% "vh") %in% c("vh", "hv", "mid")) ggfun("stairstep")(data, direction = params$direction) else data, c("GeomPath", "GeomStep"))
}

#' @export
Expand Down
1 change: 1 addition & 0 deletions tests/testthat/_snaps/ggplot-ecdf/step-ecdf.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading