Skip to content

Add stat_ecdf support #2052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Add stat_ecdf support #2052

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e6f1901
Fixed the way `GeomStep` was handeled. Closes #2011
moutikabdessabour Oct 22, 2021
943304b
Fixed some issues with the tests. And added new ones.
moutikabdessabour Oct 22, 2021
660be52
Added bug fix to NEWS.md
moutikabdessabour Oct 22, 2021
c36bd61
Conformed with carson's review
moutikabdessabour Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@

* `ggplotly()` does not issue warnings with `options(warnPartialMatchArgs = TRUE)` any longer. (#2046, @bersbersbers)

## BUG fixes

* `stat_ecdf()` now gives the correct output. (#2052)


# 4.10.0

## Breaking changes in JavaScript API
Expand Down
5 changes: 3 additions & 2 deletions R/layers2traces.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ to_basic.GeomLine <- function(data, prestats_data, layout, params, p, ...) {

#' @export
to_basic.GeomStep <- function(data, prestats_data, layout, params, p, ...) {
prefix_class(data, "GeomPath")
prefix_class(if((params$direction %||% "vh") %in% c("vh", "hv", "mid")) ggplot2:::stairstep(data, direction = params$direction) else data, c("GeomPath", "GeomStep"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ::: isn't allowed by R CMD check. Use ggfun() instead

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this breaks default geom_step() usage. See, for example, the change in tests/testthat/_snaps/ggplot-step/step-gg-hv.svg

Copy link
Contributor Author

@moutikabdessabour moutikabdessabour Nov 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I fixed the test issues. basically just re rendering the svg solved it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the tests are still broken. I don't think this is the right fix.

}

#' @export
Expand Down Expand Up @@ -623,7 +623,8 @@ to_basic.GeomQuantile <- function(data, prestats_data, layout, params, p, ...){
}

#' @export
to_basic.default <- function(data, prestats_data, layout, params, p, ...) {
to_basic.default<- function(data, prestats_data, layout, params, p, ...) {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to_basic.default<- function(data, prestats_data, layout, params, p, ...) {
to_basic.default <- function(data, prestats_data, layout, params, p, ...) {

data
}

Expand Down
1 change: 1 addition & 0 deletions tests/testthat/_snaps/ggplot-ecdf/step-ecdf.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading