-
Notifications
You must be signed in to change notification settings - Fork 34
Add integration test for removing a series from user's collection #1110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for removing a series from user's collection #1110
Conversation
Generated by 🚫 Danger |
src/main/resources/liquibase/version/0.4.1/2019-08-15--test_remove_series_from_collection.xml
Outdated
Show resolved
Hide resolved
src/main/resources/liquibase/version/0.4.1/2019-08-15--test_remove_series_from_collection.xml
Outdated
Show resolved
Hide resolved
src/main/resources/liquibase/version/0.4.1/2019-08-15--test_remove_series_from_collection.xml
Outdated
Show resolved
Hide resolved
src/main/resources/liquibase/version/0.4.1/2019-08-15--test_remove_series_from_collection.xml
Outdated
Show resolved
Hide resolved
src/main/resources/liquibase/version/0.4.1/2019-08-15--test_remove_series_from_collection.xml
Outdated
Show resolved
Hide resolved
src/main/resources/liquibase/version/0.4.1/2019-08-15--test_remove_series_from_collection.xml
Outdated
Show resolved
Hide resolved
7dee23e
to
26f92df
Compare
For future: it's better to keep use the convention that we already has -- "Fix #XXX" |
src/main/resources/liquibase/version/0.4.1/2019-08-06--test_user_with_series_in_collection.xml
Show resolved
Hide resolved
src/main/resources/liquibase/version/0.4.1/2019-08-06--test_user_with_series_in_collection.xml
Outdated
Show resolved
Hide resolved
src/main/resources/liquibase/version/0.4.1/2019-08-06--test_user_with_series_in_collection.xml
Show resolved
Hide resolved
src/main/resources/liquibase/version/0.4.1/2019-08-06--test_user_with_series_in_collection.xml
Show resolved
Hide resolved
26f92df
to
62fe0b8
Compare
*** Test Cases *** | ||
Remove a series from user's collection | ||
[Tags] unstable | ||
Go To ${SITE_URL}/series/2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far I remember we have decided to use series with id=3 We can't use a series with id=2 because it may affect collection/add-series/logic.robot
test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a comment which said to change the changeset comment to add series#1 and #2 into seriesowner collection. I thought we need to used existing series.
Now I created a series which gets id=3 and I have used it in the test case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukeshk You're right. I've checked and see that we can't use series#1 because it used by the test for searching in a collection. We can't use series#2 because we use it in the test for adding a series to collection. So, yes, the only way is to create yet another series to use in this test. I wish you told me that before so I understood it earlier ;) (it's a joke of course and I should be more careful).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments.
7907738
to
4614c55
Compare
…ies from user's collection Fix #45
4614c55
to
8fb40c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I'll merge it later. Also I'm going to add some improvements to the migration :)
@mukeshk Thank you for the contribution! it was 10th PR! 🥇 See https://github.com/php-coder/mystamps/wiki/team-members |
Addressed to #45