Skip to content

Add integration test for removing a series from user's collection #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mukeshk
Copy link
Contributor

@mukeshk mukeshk commented Aug 15, 2019

Addressed to #45

@mukeshk mukeshk requested a review from php-coder as a code owner August 15, 2019 13:35
@mystamps-bot
Copy link

1 Message
📖 @mukeshk thank you for the PR! All quality checks have been passed! Next step is to wait when @php-coder will review this code

Generated by 🚫 Danger

@mukeshk mukeshk force-pushed the gh45_test_for_removing_series_from_users_collection branch 2 times, most recently from 7dee23e to 26f92df Compare August 15, 2019 16:04
@php-coder
Copy link
Owner

test(collection/remove-series): add integration test for removing series from user's collection

Fixed #45

For future: it's better to keep use the convention that we already has -- "Fix #XXX"

@mukeshk mukeshk self-assigned this Aug 16, 2019
@mukeshk mukeshk force-pushed the gh45_test_for_removing_series_from_users_collection branch from 26f92df to 62fe0b8 Compare August 16, 2019 08:49
*** Test Cases ***
Remove a series from user's collection
[Tags] unstable
Go To ${SITE_URL}/series/2
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far I remember we have decided to use series with id=3 We can't use a series with id=2 because it may affect collection/add-series/logic.robot test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a comment which said to change the changeset comment to add series#1 and #2 into seriesowner collection. I thought we need to used existing series.

Now I created a series which gets id=3 and I have used it in the test case.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshk You're right. I've checked and see that we can't use series#1 because it used by the test for searching in a collection. We can't use series#2 because we use it in the test for adding a series to collection. So, yes, the only way is to create yet another series to use in this test. I wish you told me that before so I understood it earlier ;) (it's a joke of course and I should be more careful).

Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments.

@mukeshk mukeshk force-pushed the gh45_test_for_removing_series_from_users_collection branch 2 times, most recently from 7907738 to 4614c55 Compare August 16, 2019 15:07
@mukeshk mukeshk force-pushed the gh45_test_for_removing_series_from_users_collection branch from 4614c55 to 8fb40c8 Compare August 16, 2019 15:09
Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll merge it later. Also I'm going to add some improvements to the migration :)

@php-coder php-coder merged commit dfb6c9d into php-coder:master Aug 17, 2019
@php-coder
Copy link
Owner

@mukeshk Thank you for the contribution! it was 10th PR! 🥇 See https://github.com/php-coder/mystamps/wiki/team-members

@mukeshk mukeshk deleted the gh45_test_for_removing_series_from_users_collection branch August 20, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants