-
Notifications
You must be signed in to change notification settings - Fork 34
Add integration test for removing series from user's collection #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I've just broke it during refactoring for #440 and didn't notice that because our tests don't cover this case. |
Do we consider "seriesowner" login for this test? @general - Our test cases should restore the state of the system back to its original state? |
@mukeshk Thank you for the questions! Yes, we should use "seriesowner" in this test. The tests don't need to restore the state but we should keep in mind that if more than one tests share the same data, we shouldn't modify this data to keep other tests working. So, that's why in this case, I suggest to update the migration and add yet another series to "seriesowner" collection. That new series we can safely remove from his collection then. |
Sure. I understand will work accordingly. |
When I create a record in series, michel_catalog scott_catalog yvert_catalog gibbons_catalog |
No, just a series is enough. Additional meta information isn't needed as it isn't required by a test case. |
sure. I am almost done with it. I just inserted in the series table before your reply. |
…ies from user's collection Fixed #45
…ies from user's collection Fixed #45
…ies from user's collection Fixed #45
When user opens series info page, he should see a button for removing series from collection. When he clicks on it, he should be redirected to collection page where this series shouldn't be listed.
Technical Debt for: 227b9a5 (#2)
The text was updated successfully, but these errors were encountered: