Skip to content

Add integration test for removing series from user's collection #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
php-coder opened this issue Sep 14, 2014 · 7 comments
Closed

Add integration test for removing series from user's collection #45

php-coder opened this issue Sep 14, 2014 · 7 comments
Assignees
Milestone

Comments

@php-coder
Copy link
Owner

When user opens series info page, he should see a button for removing series from collection. When he clicks on it, he should be redirected to collection page where this series shouldn't be listed.

Technical Debt for: 227b9a5 (#2)

@php-coder
Copy link
Owner Author

I've just broke it during refactoring for #440 and didn't notice that because our tests don't cover this case.

@php-coder php-coder added this to the next milestone Oct 23, 2016
@php-coder php-coder modified the milestones: 0.5, next May 17, 2017
@php-coder php-coder modified the milestones: 0.5, 0.4.1 Jul 15, 2019
@mukeshk mukeshk self-assigned this Aug 14, 2019
@mukeshk
Copy link
Contributor

mukeshk commented Aug 14, 2019

Do we consider "seriesowner" login for this test?
Series owner has "series/1" - on collection/seriesowner page.
Should we use this as a test data? - like we remove it?

@general - Our test cases should restore the state of the system back to its original state?
Like we remove it and then should we restore it back?

@php-coder
Copy link
Owner Author

@mukeshk Thank you for the questions!

Yes, we should use "seriesowner" in this test.

The tests don't need to restore the state but we should keep in mind that if more than one tests share the same data, we shouldn't modify this data to keep other tests working. So, that's why in this case, I suggest to update the migration and add yet another series to "seriesowner" collection. That new series we can safely remove from his collection then.

@mukeshk
Copy link
Contributor

mukeshk commented Aug 15, 2019

Sure. I understand will work accordingly.

@mukeshk
Copy link
Contributor

mukeshk commented Aug 15, 2019

When I create a record in series,
Do I need to create records in
Ref: test-series-with-catalogs-numbers.sql

michel_catalog
series_michel_catalog

scott_catalog
series_scott_catalog

yvert_catalog
series_yvert_catalog

gibbons_catalog
series_gibbons_catalog

@php-coder
Copy link
Owner Author

No, just a series is enough. Additional meta information isn't needed as it isn't required by a test case.

@mukeshk
Copy link
Contributor

mukeshk commented Aug 15, 2019

sure. I am almost done with it. I just inserted in the series table before your reply.

mukeshk referenced this issue in mukeshk/mystamps Aug 15, 2019
mukeshk referenced this issue in mukeshk/mystamps Aug 15, 2019
mukeshk referenced this issue in mukeshk/mystamps Aug 15, 2019
mukeshk referenced this issue in mukeshk/mystamps Aug 16, 2019
mukeshk referenced this issue in mukeshk/mystamps Aug 16, 2019
mukeshk referenced this issue in mukeshk/mystamps Aug 16, 2019
mukeshk referenced this issue in mukeshk/mystamps Aug 16, 2019
@php-coder php-coder added the estimation/30m Estimated time: 30 minutes label Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants