Skip to content

Add integration test for removing a series from user's collection #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.0.xsd">

<changeSet id="create-a-user-with-a-series-in-his-collection" author="mukeshk" context="test-data">
<comment>Creates the user "seriesowner" that has series #1 in its collection</comment>
<comment>Creates the user "seriesowner" that has series #1 and #3 in its collection</comment>
<insert tableName="users">
<column name="login" value="seriesowner" />
<column name="role" value="USER" />
Expand All @@ -30,6 +30,22 @@
<column name="series_id" value="1" />
<column name="number_of_stamps" value="1" />
</insert>

<insert tableName="series">
<column name="quantity" valueNumeric="5" />
<column name="perforated" valueBoolean="TRUE" />
<column name="category_id" valueNumeric="1" />
<column name="created_at" valueComputed="${NOW}" />
<column name="created_by" valueComputed="(SELECT id FROM users WHERE login = 'seriesowner')" />
<column name="updated_at" valueComputed="${NOW}" />
<column name="updated_by" valueComputed="(SELECT id FROM users WHERE login = 'seriesowner')" />
</insert>

<insert tableName="collections_series">
<column name="collection_id" valueComputed="(SELECT id FROM collections WHERE slug = 'seriesowner')" />
<column name="series_id" valueNumeric="3" />
<column name="number_of_stamps" valueNumeric="3" />
</insert>
</changeSet>

</databaseChangeLog>
2 changes: 1 addition & 1 deletion src/main/webapp/WEB-INF/views/series/info.html
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ <h5 class="text-center" th:text="#{t_similar_series}">

<!--/*/
<div class="col-sm-12" th:if="${isSeriesInCollection}" sec:authorize="hasAuthority('UPDATE_COLLECTION')">
<form method="post" action="../collection/info.html" th:action="@{${INFO_SERIES_PAGE}(id=${series.id})}">
<form id="remove-series-form" method="post" action="../collection/info.html" th:action="@{${INFO_SERIES_PAGE}(id=${series.id})}">
<p th:text="#{t_series_in_collection}">
Series is part of your collection
</p>
Expand Down
20 changes: 20 additions & 0 deletions src/test/robotframework/collection/remove-series/logic.robot
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
*** Settings ***
Documentation Verify series removal from a user's collection
Library SeleniumLibrary
Resource ../../auth.steps.robot
Suite Setup Before Test Suite
Suite Teardown Close Browser
Force Tags collection series logic

*** Test Cases ***
Remove a series from user's collection
[Tags] unstable
Go To ${SITE_URL}/series/3
Submit Form id=remove-series-form
Page Should Not Contain Link css=[href="/series/3"]

*** Keywords ***
Before Test Suite
Open Browser ${SITE_URL}/account/auth ${BROWSER}
Register Keyword To Run On Failure Log Source
Log In As login=seriesowner password=test