Skip to content

Series import: move configuration of the site parsers to database #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
php-coder opened this issue Dec 2, 2018 · 4 comments
Closed

Comments

@php-coder
Copy link
Owner

php-coder commented Dec 2, 2018

At this moment, site parsers configuration is staticly defined in the application.properties file(s). It means that when we add one more parser or changes the property of one of the existing, we have to restart the application.

The first issue, that once broke the site already, is that ansible role doesn't support app.site-parsers* properties yet (see #929). If we move these properties to database, we won't need such a support at all.

The second issue is that restarting of the application slow us down when we working on the adding a new site parser. If we would have such configuration in database, we won't have this difficulty and adding a new site parser (or fixing the existing one) will be much faster. In this case, we should read the configuration from database not just once, during application startup, but for every import request.

@php-coder php-coder added this to the 0.4 milestone Dec 2, 2018
@php-coder php-coder self-assigned this Dec 3, 2018
php-coder added a commit that referenced this issue Dec 3, 2018
php-coder added a commit that referenced this issue Dec 15, 2018
@0pdd
Copy link

0pdd commented Dec 15, 2018

@php-coder the puzzle #982 is still not solved.

php-coder added a commit that referenced this issue Dec 15, 2018
php-coder added a commit that referenced this issue Dec 15, 2018
BREAKING CHANGE: site parsers from application.properties are now ignored. It's supposed that they
have been migrated by running application with the code from previous commit. Otherwise,
administrator can migrate them manually.

Addressed to #975
@0pdd
Copy link

0pdd commented Dec 15, 2018

@php-coder 2 puzzles #982, #983 are still not solved.

@0pdd
Copy link

0pdd commented Dec 15, 2018

@php-coder 3 puzzles #982, #983, #984 are still not solved.

@php-coder
Copy link
Owner Author

Done!

php-coder added a commit that referenced this issue Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants