-
Notifications
You must be signed in to change notification settings - Fork 34
Series import: move configuration of the site parsers to database #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
php-coder
added a commit
that referenced
this issue
Dec 3, 2018
…ion. Addressed to #975 No functional changes.
php-coder
added a commit
that referenced
this issue
Dec 15, 2018
…on.properties file to database. Addressed to #975
@php-coder the puzzle #982 is still not solved. |
php-coder
added a commit
that referenced
this issue
Dec 15, 2018
BREAKING CHANGE: site parsers from application.properties are now ignored. It's supposed that they have been migrated by running application with the code from previous commit. Otherwise, administrator can migrate them manually. Addressed to #975
@php-coder 2 puzzles #982, #983 are still not solved. |
php-coder
added a commit
that referenced
this issue
Dec 15, 2018
@php-coder 3 puzzles #982, #983, #984 are still not solved. |
php-coder
added a commit
that referenced
this issue
Dec 16, 2018
…abase for test and travis profiles. Addressed to #975 No functional changes.
This was referenced Dec 17, 2018
php-coder
added a commit
that referenced
this issue
Dec 17, 2018
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At this moment, site parsers configuration is staticly defined in the
application.properties
file(s). It means that when we add one more parser or changes the property of one of the existing, we have to restart the application.The first issue, that once broke the site already, is that ansible role doesn't support
app.site-parsers*
properties yet (see #929). If we move these properties to database, we won't need such a support at all.The second issue is that restarting of the application slow us down when we working on the adding a new site parser. If we would have such configuration in database, we won't have this difficulty and adding a new site parser (or fixing the existing one) will be much faster. In this case, we should read the configuration from database not just once, during application startup, but for every import request.
The text was updated successfully, but these errors were encountered: