refactor: load list of site parsers from database.

Addressed to #975

Author: php-coder

src/main/java/ru/mystamps/web/feature/series/importing/event/DownloadingSucceededEventListener.java

@@ -59,11 +59,10 @@ public class DownloadingSucceededEventListener
 
 	@PostConstruct
 	public void init() {
-		// TODO: get all parser names from database
-		log.info("Registered site parsers: {}", siteParsers);
-		
 		// TODO: remove migration logic after finishing migration
 		siteParsers.forEach(this::migrateParser);
+		
+		log.info("Registered site parsers: {}", siteParserService.findParserNames());
 	}
 
 	@Override

src/main/java/ru/mystamps/web/feature/series/importing/extractor/JdbcSiteParserDao.java

@@ -19,6 +19,7 @@
 
 import java.util.Collections;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 
 import org.apache.commons.lang3.Validate;
@@ -50,6 +51,9 @@ public class JdbcSiteParserDao implements SiteParserDao {
 	@Value("${site_parser.find_like_matched_url}")
 	private String findParserIdByMatchedUrl;
 
+	@Value("${site_parser.find_names}")
+	private String findParserNamesSql;
+	
 	@SuppressWarnings("PMD.LongVariable")
 	@Value("${site_parser_param.find_all_with_parser_name}")
 	private String findParametersWithParserNameSql;
@@ -102,6 +106,15 @@ public Integer findParserIdForUrl(String url) {
 		}
 	}
 
+	@Override
+	public List<String> findParserNames() {
+		return jdbcTemplate.queryForList(
+			findParserNamesSql,
+			Collections.emptyMap(),
+			String.class
+		);
+	}
+	
 	@Override
 	public SiteParserConfiguration findConfigurationForParser(Integer parserId) {
 		Map<String, String> params = jdbcTemplate.query(

src/main/java/ru/mystamps/web/feature/series/importing/extractor/SiteParserDao.java

@@ -17,9 +17,12 @@
  */
 package ru.mystamps.web.feature.series.importing.extractor;
 
+import java.util.List;
+
 public interface SiteParserDao {
 	Integer addParser(String name);
 	void addParserParameter(AddParserParameterDbDto param);
 	Integer findParserIdForUrl(String url);
+	List<String> findParserNames();
 	SiteParserConfiguration findConfigurationForParser(Integer parserId);
 }

src/main/java/ru/mystamps/web/feature/series/importing/extractor/SiteParserService.java

@@ -17,7 +17,10 @@
  */
 package ru.mystamps.web.feature.series.importing.extractor;
 
+import java.util.List;
+
 public interface SiteParserService {
 	void add(SiteParserConfiguration cfg);
 	SiteParser findForUrl(String url);
+	List<String> findParserNames();
 }

src/main/java/ru/mystamps/web/feature/series/importing/extractor/SiteParserServiceImpl.java

@@ -17,6 +17,7 @@
  */
 package ru.mystamps.web.feature.series.importing.extractor;
 
+import java.util.List;
 import java.util.Map;
 
 import org.apache.commons.lang3.Validate;
@@ -80,4 +81,11 @@ public SiteParser findForUrl(String url) {
 		return new JsoupSiteParser(cfg);
 	}
 
+	// @todo #975 SiteParserServiceImpl.findParserNames(): add unit tests
+	@Override
+	@Transactional(readOnly = true)
+	public List<String> findParserNames() {
+		return siteParserDao.findParserNames();
+	}
+	
 }

src/main/resources/sql/site_parser_dao_queries.properties

@@ -23,6 +23,11 @@ SELECT parser_id AS id \
    AND value = :url \
     OR :url LIKE CONCAT(value, '%')
 
+site_parser.find_names = \
+  SELECT name \
+    FROM site_parsers \
+ORDER BY id
+
 site_parser_param.find_all_with_parser_name = \
 SELECT name \
      , value \