Skip to content

Series import: validate app.site-parser[x].*-locator properties #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
php-coder opened this issue Dec 7, 2017 · 1 comment
Closed

Comments

@php-coder
Copy link
Owner

Let's use QueryParser.parse(locator) to ensue that properties are valid locators. If they aren't we will handle SelectorParseException and fail-fast during application initialization.

@php-coder
Copy link
Owner Author

After fixing #975 the properties will live in database and we won't have code that validates the properties (see also #842 ). I'm not sure that we need validation for them at this stage because such errors should not happen as only admin adds these properties to database. Even if they occurs, the chance is really small and in that case we may circle back to this discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant