Add integration tests for collection estimation page

[0pdd]

The puzzle 884-d2a3ddba from #884 has to be resolved:

mystamps/src/main/java/ru/mystamps/web/controller/CollectionController.java

Line 107 in 9287473

// @todo #884 Add integration tests for collection estimation page

The puzzle was created by Slava Semushin on 20-Jun-18.

---

I see that we can have at least the following 3 tests:

0. Before Test Suite:

   • login as paid user (with a password test)

1. Message should be shown when a collection is empty

   • open /collection/paid/estimation
   • the message "In this collection is no stamps" should be shown

2. Series with its price should be taken into account

   • open /series/1 and it to the collection with a some price (let's use 100) and random currency
   • open /collection/paid/estimation page
   • the series should be listed and price should be 100 $currency (perhaps, we can use Table Row Should Contain for that? or Get Table Cell)
   • Total should be 100 $currency (perhaps, we can use Table Footer Should Contain for that?)

3. Series without price should be shown but not taken into account

   • open /series/2
   • add this series without specifying a price
   • the series should be listed without price
   • Total should be the same as before (100 $currency)

Notes:

• test cases should be placed into src/test/robotframework/collection/estimation/logic.robot file

[mukeshk]

"Selenium.Utils.Robot": Select Random Option From List, - doesn't support option to skip a blank option element. Can I add an argument startIndex, which will indicate the start index in the options list?
So if we configure,
Select Random Option From List id="paid-currency" 1
in another place, where the first option is not blank we can pass
Select Random Option From List id=catalogName 0

The idea was to reuse random selection keyword which we implemented earlier.

[php-coder]

@mukeshk Thank you for the good question! Yes, I think we should modify this keyword and re-use it. But I'd suggest to implement it a little differently:

• add parameter "ignoreEmptyOption" and set it to false by default (for backward compatibility; do we need it?)
• use if + Remove Values From List to remove an empty value when this option is set to true

WDYT?

[mukeshk]

I was thinking about boolean was not sure how I could manipulate list in robot script. I agree with your suggestions. Will check it out. Thanks and best regards Mukesh

…

On Wed 28 Aug, 2019, 3:45 PM Slava Semushin, ***@***.***> wrote: @mukeshk <https://github.com/mukeshk> Thank you for the good question! Yes, I think we should modify this keyword and re-use it. But I'd suggest to implement it a little differently: - add parameter "ignoreEmptyOption" and set it to "false" by default (for backward compatibility) - use if + Remove Values From List <http://robotframework.org/robotframework/3.0.3/libraries/Collections.html#Remove%20Values%20From%20List> to remove an empty value WDYT? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#893?email_source=notifications&email_token=AAJPE6DWW7JYQAXEC5S72ALQGZF5FA5CNFSM4FGIEJP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5KTVJI#issuecomment-525679269>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJPE6H4SZFCYB2QEJA27BTQGZF5FANCNFSM4FGIEJPQ> .

[mukeshk]

${options}=                Get List Items  ${locator}
${size}=                   Get Length  ${options}
${randomIndex}=            Evaluate  random.randint(0, ${size}-1)  modules=random
Select From List By Index  ${locator}  ${randomIndex}

if we remove empty values from ${options} . Then we will not able to correctly identify the index , since size of array will change.

1. Should we have ignoreFirstOption?
   Or
2. Should we change

Get List Items ${locator}  - to - Get List Items ${locator} value=${True}
    Run Keyword If ${ignoreEmptyValue}  .... remove..
    ${size}=                   Get Length  ${options}
    ${randomValue}=            Evaluate  random.randint(0, ${size}-1)  modules=random
    Select From List By Value  ${locator}  ${randomValue}
    

[php-coder]

@mukeshk Very good point!

I agree that we should use Select From List By Value instead of Select From List By Index in this case.

Select From List By Value  ${locator}  ${randomValue}

Should be something like

     Select From List By Value  ${locator}  @{options}[${randomValue}]

[php-coder]

P.S. https://stackoverflow.com/questions/42576003/fetch-value-from-list-in-robot-framework might be helpful.

[mukeshk]

Remove Values From List ${options} "" ' ' '' null is not working as expected.
the original drop-down contains five options.

Should we change the first option to value="" in the series/info.html.

[mukeshk]

in the collection\estimation.html page - for the cell are represented by th instead of td.
The above image i have converted the th to td.
The keyword "Table Footer Should Contain" works with tfoot - containing - td .
it does not work with a tfoot containing th.

If I convert the th to td, we lose the bold formatting, should i apply bold tag to the content so that it looks like th - text content.

[mukeshk]

We get the data table error after we submit the "add-series-form".
The same which is due to the charts. So this test also we need to tag as unstable.

[php-coder]

Remove Values From List ${options} "" ' ' '' null is not working as expected.

It's not what I expected actually :) Would it work with ${EMPTY}?

Remove Values From List ${options}  ${EMPTY}

[php-coder]

The keyword "Table Footer Should Contain" works with tfoot - containing - td . it does not work with a tfoot containing th.

Thanks for finding and reporting this! I've done the same -- reported it back to upstream: MarketSquare/robotframework-seleniumlibrary-java#88

As I looked to the sources I found out that due to a little weird behavior of "Table Header Should Contain" we can use it for checking the footer :) See MarketSquare/robotframework-seleniumlibrary-java#89 for details.

What do you think?

[php-coder]

P.S. Anyway, it both these keywords won't work for us, we can get elements and their text by CSS/XPath/etc as we do with other elements.

[php-coder]

We get the data table error after we submit the "add-series-form". The same which is due to the charts. So this test also we need to tag as unstable.

Hm, you're right. Thank you for letting me know.

By the way, if you have a code, it's always better to discuss details in the PR ;)

[mukeshk]

Remove Values From List ${options} "" ' ' '' null is not working as expected.

It's not what I expected actually :) Would it work with ${EMPTY}?

Remove Values From List ${options}  ${EMPTY}

You rock !!! it works :)

[mukeshk]

The keyword "Table Footer Should Contain" works with tfoot - containing - td . it does not work with a tfoot containing th.

Thanks for finding and reporting this! I've done the same -- reported it back to upstream: Hi-Fi/robotframework-seleniumlibrary-java#88

As I looked to the sources I found out that due to a little weird behavior of "Table Header Should Contain" we can use it for checking the footer :) See Hi-Fi/robotframework-seleniumlibrary-java#89 for details.

What do you think?

Again Table Header Should Contain ... It works.