Skip to content
This repository was archived by the owner on Feb 2, 2025. It is now read-only.

"Table Footer Should Contain" should take into account <th> elements #88

Closed
php-coder opened this issue Aug 29, 2019 · 1 comment
Closed

"Table Footer Should Contain" should take into account <th> elements #88

php-coder opened this issue Aug 29, 2019 · 1 comment

Comments

@php-coder
Copy link

Table Footer Should Contain is always looking for <td> tags within <tfoot>:

https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/blob/fed6f0e95b5cf5a365f8357a9976ec9ed7ff7e1e/src/main/java/com/github/markusbernhardt/seleniumlibrary/locators/TableElementFinder.java#L17

but it's valid to have <th> tags here also. Example: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tfoot

Can we have this keyword fixed to take into account <th> tags as well?
@php-coder php-coder mentioned this issue Aug 29, 2019
Closed
@php-coder
Copy link
Author

php-coder commented Aug 29, 2019 •
edited
Loading

I've submitted this to the upstream as well: robotframework/SeleniumLibrary#1436

Hi-Fi added a commit that referenced this issue Nov 11, 2019
@Hi-Fi
Fixes #88
239cb42
Hi-Fi added a commit that referenced this issue Nov 12, 2019
@Hi-Fi
Fixes #88
2412ef5 
Added commong-lang3 explicitly as dependency

Refactoring of array handling

Using StringUtils instead of custom Python join
@Hi-Fi Hi-Fi closed this as completed in 6160afc Nov 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@php-coder