Skip to content
This repository was archived by the owner on Feb 2, 2025. It is now read-only.

"Table Header Should Contain" might get <th> elements from footer #89

Closed
php-coder opened this issue Aug 29, 2019 · 2 comments
Closed

Comments

@php-coder
Copy link

Table Header Should Contain keyword is looking for <th> elements everywhere in a table:

https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/blob/fed6f0e95b5cf5a365f8357a9976ec9ed7ff7e1e/src/main/java/com/github/markusbernhardt/seleniumlibrary/locators/TableElementFinder.java#L16

Given that <th> tag can be enclosed within <tfoot>, it doesn't seem right to treat it as a header.

@php-coder
Copy link
Author

php-coder commented Aug 29, 2019

I've submitted this to the upstream too: robotframework/SeleniumLibrary#1437

@Hi-Fi
Copy link
Collaborator

Hi-Fi commented Nov 11, 2019

This is not so straight forward, as th is header at every place, even at rows (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/th).

This is also how the keyword is documented; Verify the content of any table header cells of the table

@Hi-Fi Hi-Fi closed this as completed Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants