Skip to content

Import series: connect import request with created series #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Nov 10, 2017 · 3 comments
Closed

Import series: connect import request with created series #700

php-coder opened this issue Nov 10, 2017 · 3 comments
Assignees
@php-coder
Labels
kind/improvement
Milestone
0.4

Comments

@php-coder
Copy link
Owner

When import request is successful, we should show a link to a page with series.
@php-coder php-coder self-assigned this Nov 22, 2017
@php-coder php-coder added this to the 0.4 milestone Nov 22, 2017
php-coder added a commit that referenced this issue Nov 22, 2017
@php-coder
/series/import/request/{id}: show a link to imported series.
e261d5e 
For now, only add a field to database and show a link on the page. Support for inserting a series id
after import will be added later.

Addressed to #700
@php-coder php-coder changed the title Connect import request with created series Import series: connect import request with created series Nov 22, 2017
@php-coder php-coder mentioned this issue Nov 22, 2017
Closed
@php-coder
Copy link
Owner Author

Note, that currently there is no code that will change request status from ParsingSucceeded into ImportSucceeded.

@php-coder
Copy link
Owner Author

Don't forget to add an integration test.

php-coder added a commit that referenced this issue Dec 2, 2017
@php-coder
SeriesImportService: rename add() to addRequest().
c4fe009 
Prerequisite for #700

No functional changes.
php-coder added a commit that referenced this issue Dec 2, 2017
@php-coder
SeriesImportService.addSeries(): extract method.
6f6b733 
Addressed to #700

No functional changes.
This was referenced Dec 2, 2017
Closed
Closed
Closed
@0pdd
Copy link

0pdd commented Feb 17, 2019

@php-coder the puzzle #757 is still not solved; solved: #734, #735, #736, #756.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
kind/improvement
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@php-coder @0pdd