Skip to content

Commit e261d5e

Browse files
committed
/series/import/request/{id}: show a link to imported series.
For now, only add a field to database and show a link on the page. Support for inserting a series id after import will be added later. Addressed to #700
1 parent 3b6a706 commit e261d5e

File tree

9 files changed

+44
-5
lines changed

9 files changed

+44
-5
lines changed

src/main/java/ru/mystamps/web/dao/dto/ImportRequestDto.java

+1
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,5 @@
2727
public class ImportRequestDto {
2828
private final String url;
2929
private final String status;
30+
private final Integer seriesId;
3031
}

src/main/java/ru/mystamps/web/dao/impl/RowMappers.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,8 @@ public static TransactionParticipantDto forTransactionParticipantDto(ResultSet r
274274
public static ImportRequestDto forImportRequestDto(ResultSet rs, int i) throws SQLException {
275275
return new ImportRequestDto(
276276
rs.getString("url"),
277-
rs.getString("status")
277+
rs.getString("status"),
278+
JdbcUtils.getInteger(rs, "series_id")
278279
);
279280
}
280281

src/main/resources/liquibase/version/0.4.xml

+1
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,6 @@
3939
<include file="0.4/2017-11-09--countries_aliases.xml" relativeToChangelogFile="true" />
4040
<include file="0.4/2017-11-14--separate_buyers_and_sellers.xml" relativeToChangelogFile="true" />
4141
<include file="0.4/2017-11-15--group_participants.xml" relativeToChangelogFile="true" />
42+
<include file="0.4/2017-11-22--import_request_series_id.xml" relativeToChangelogFile="true" />
4243

4344
</databaseChangeLog>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<databaseChangeLog
3+
xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
4+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
5+
xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
6+
http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.1.xsd">
7+
8+
<changeSet id="connect-series_import_requests-and-series-table" author="php-coder" context="scheme">
9+
10+
<addColumn tableName="series_import_requests">
11+
<column name="series_id" type="INTEGER" afterColumn="status_id">
12+
<constraints references="series(id)" foreignKeyName="fk_series_import_requests_series_id" />
13+
</column>
14+
</addColumn>
15+
16+
</changeSet>
17+
18+
</databaseChangeLog>

src/main/resources/ru/mystamps/i18n/Messages.properties

+1
Original file line numberDiff line numberDiff line change
@@ -194,5 +194,6 @@ t_submit_request = Submit request
194194
# series/import/info.html
195195
t_import_request = import request
196196
t_status = Status
197+
t_imported_series = Imported series
197198
t_gathered_data = Gathered data
198199
t_proceed_to_series_creation = Proceed to series creation

src/main/resources/ru/mystamps/i18n/Messages_ru.properties

+1
Original file line numberDiff line numberDiff line change
@@ -194,5 +194,6 @@ t_submit_request = Создать запрос
194194
# series/import/info.html
195195
t_import_request = запрос на импорт
196196
t_status = Статус
197+
t_imported_series = Импортированная серия
197198
t_gathered_data = Собранные данные
198199
t_proceed_to_series_creation = Перейти к добавлению серии

src/main/resources/sql/series_import_request_dao_queries.properties

+3-2
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,9 @@ UPDATE series_import_requests r \
3333
)
3434

3535
series_import_requests.find_by_id = \
36-
SELECT r.url, \
37-
s.name AS status \
36+
SELECT r.url \
37+
, s.name AS status \
38+
, r.series_id \
3839
FROM series_import_requests r \
3940
JOIN series_import_request_statuses s \
4041
ON r.status_id = s.id \

src/main/webapp/WEB-INF/views/series/import/info.html

+16-1
Original file line numberDiff line numberDiff line change
@@ -156,14 +156,29 @@ <h3 th:text="#{t_gathered_data}">
156156
type="submit"
157157
class="btn btn-primary"
158158
value="Proceed to series creation"
159-
th:value="#{t_proceed_to_series_creation}" />
159+
th:value="#{t_proceed_to_series_creation}"
160+
th:disabled="${request.seriesId != null}" />
160161
</td>
161162
</tr>
162163
</table>
163164
</div>
164165
</form>
165166

166167
</div>
168+
169+
<!--/*/
170+
<div class="col-sm-4 col-sm-offset-4" th:if="${request.seriesId != null}">
171+
<h3 th:text="#{t_imported_series}">
172+
Imported series
173+
</h3>
174+
175+
<div class="text-center">
176+
<a th:href="@{${INFO_SERIES_PAGE}(id=${request.seriesId})}"
177+
th:text="@{${PUBLIC_URL} + ${INFO_SERIES_PAGE}(id=${request.seriesId})}"></a>
178+
</div>
179+
</div>
180+
/*/-->
181+
167182
</div>
168183
<div class="row">
169184
<footer class="col-sm-12 text-right">

src/test/java/ru/mystamps/web/service/TestObjects.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ public static EntityWithIdDto createEntityWithIdDto() {
183183
}
184184

185185
public static ImportRequestDto createImportRequestDto() {
186-
return new ImportRequestDto(Random.url(), Random.importRequestStatus());
186+
return new ImportRequestDto(Random.url(), Random.importRequestStatus(), null);
187187
}
188188

189189
public static ParsedDataDto createParsedDataDto() {

0 commit comments

Comments
 (0)