Skip to content

SeriesImportServiceImpl.addSeries(): reduce number of SQL queries #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
0pdd opened this issue Dec 2, 2017 · 1 comment
Closed

SeriesImportServiceImpl.addSeries(): reduce number of SQL queries #735

0pdd opened this issue Dec 2, 2017 · 1 comment
Assignees
@php-coder
Labels
refactoring techdebt
Milestone
0.4

Comments

@0pdd
Copy link

0pdd commented Dec 2, 2017 •
edited by php-coder
Loading

The puzzle 700-3a29b76a (from #700) in src/main/java/ru/mystamps/web/service/SeriesImportServiceImpl.java (lines 94-96) has to be resolved: "Reduce number of SQL queries by one. Here we're updating series_import_requests twice: when we set series_id field and later when we change status_id. It's possible to do this in one-shot"

The puzzle was created by Slava Semushin on 02-Dec-17.

Tech debt for: 676ad28 (#700)
0pdd referenced this issue Dec 2, 2017
@php-coder
Import series: connect import request with created series.
676ad28 
Fix #700
@php-coder php-coder changed the title SeriesImportServiceImpl.java:94-96: Reduce number of SQL queries by one.... SeriesImportServiceImpl.addSeries(): reduce number of SQL queries Dec 2, 2017
@php-coder php-coder added this to the 0.4 milestone Dec 14, 2017
@php-coder php-coder self-assigned this Dec 14, 2017
@0pdd 0pdd mentioned this issue Dec 14, 2017
Closed
@0pdd 0pdd mentioned this issue Feb 17, 2019
Closed
@0pdd
Copy link
Author

0pdd commented Feb 17, 2019

@0pdd the only puzzle #756 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
refactoring techdebt
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@php-coder @0pdd