Skip to content

Use random values in unit tests #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
10 of 47 tasks
php-coder opened this issue Dec 30, 2015 · 1 comment
Open
10 of 47 tasks

Use random values in unit tests #300

php-coder opened this issue Dec 30, 2015 · 1 comment
Assignees
@php-coder
Labels
area/unit tests kind/improvement
Milestone
next

Comments

@php-coder
Copy link
Owner

php-coder commented Dec 30, 2015 •
edited
Loading

Replace all occurrences of static values to random. If we need an integer we should return random integer. If we need a string we need to return string with random parts of letters in it.

TODO:

  • evaluate CategoryServiceImplTest
    • random id
    • random count
    • random category slug
    • random category name in English
    • random category name in Russian
    • random 2-letters language
    • random date
  • evaluate CollectionServiceImplTest
    • random id
    • random user login
    • random boolean
    • random count
    • random date
    • random quantity
    • random collection slug
  • evaluate CountryServiceImplTest
    • random id
    • random count
    • random category slug
    • random category name in English
    • random category name in Russian
    • random 2-letters language
    • random date
  • evaluate CronServiceImplTest
  • evaluate DatabaseImagePersistenceStrategyTest
    • random bytes
    • random id
  • evaluate FilesystemImagePersistenceStrategyTest
    • random bytes
  • evaluate ImageServiceImplTest
  • evaluate SeriesSalesServiceImplTest
  • evaluate SeriesServiceImplTest
  • evaluate SiteServiceImplTest
  • evaluate StampsCatalogServiceImplTest
  • evaluate SuspiciousActivityServiceImplTest
  • evaluate TimedImagePreviewStrategyTest
    • random bytes
  • evaluate TransactionParticipantServiceImplTest
    • random participant name
    • random participant url
  • evaluate UsersActivationServiceImplTest
  • evaluate UserServiceImplTest
  • evaluate CatalogUtilsTest
  • evaluate LocaleUtilsTest
  • evaluate PagerTest
  • evaluate SlugUtilsTest
@php-coder
Copy link
Owner Author

php-coder commented Apr 21, 2016 •
edited
Loading

Maybe this project could be useful: https://github.com/qala-io/datagen

@php-coder php-coder added this to the next milestone Jul 29, 2016
@Shkarin Shkarin mentioned this issue Aug 23, 2017
Closed
php-coder added a commit that referenced this issue Oct 3, 2017
@php-coder
ContentSecurityPolicyHeaderWriterTest: use random values in test.
9d47a0a 
Addressed to #300
@php-coder php-coder self-assigned this Oct 3, 2017
php-coder added a commit that referenced this issue Oct 6, 2017
@php-coder
UserServiceImplTest: use a random value for user id instead of a cons…
2ac9ee5 
…tant.

Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Oct 6, 2017
@php-coder
CategoryServiceImplTest: use a random value for user id instead of a …
81195ab 
…constant.

Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Oct 6, 2017
@php-coder
CountryServiceImplTest: use a random value for user id instead of a c…
a576a93 
…onstant.

Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Oct 6, 2017
@php-coder
SeriesServiceImplTest: use a random value for user id instead of a me…
2f2ef23 
…mber.

Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Oct 6, 2017
@php-coder
TestObjects: use a random value for user id instead of a constant.
c1286f9 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Nov 20, 2017
@php-coder
TestObjects: propagate Random.id().
32f6a20 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Nov 20, 2017
@php-coder
TestObjects: propagate bool().
62c8a07 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Nov 20, 2017
@php-coder
TestObjects: propagate Random.userId().
4eb81af 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Nov 20, 2017
@php-coder
TestObjects: propagate Random.issueYear().
321ce5b 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Dec 29, 2017
@php-coder
SeriesServiceImplTest: propagate Random.price().
5162442 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Dec 29, 2017
@php-coder
SeriesServiceImplTest(add() should pass gibbons price and currency to…
6cdd0fc 
… series dao): use random values.

Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Feb 8, 2018
@php-coder
SeriesServiceImplTest: propagate Random.catalogNumber().
683489d 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Feb 8, 2018
@php-coder
SeriesServiceImplTest: propagate Random.id().
aaf63d2 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Feb 8, 2018
@php-coder
SeriesServiceImplTest: propagate Random.userId().
f9e3ab4 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Feb 8, 2018
@php-coder
SeriesServiceImplTest: propagate bool().
6e038f6 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Feb 8, 2018
@php-coder
SeriesServiceImplTest: propagate Random.lang().
6c30fc8 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Feb 8, 2018
@php-coder
SeriesServiceImplTest: propagate Random.quantity().
f565d53 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Feb 8, 2018
@php-coder
SeriesServiceImplTest: propagate Random.perforated().
d3a5984 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Feb 8, 2018
@php-coder
SeriesServiceImplTest: propagate positiveLong().
51a5393 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Feb 8, 2018
@php-coder
SeriesServiceImplTest: propagate positiveInteger().
7ab0792 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Feb 8, 2018
@php-coder
SeriesServiceImplTest: propagate TestObjects.createImageInfoDto().
0934674 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Feb 8, 2018
@php-coder
SeriesServiceImplTest: propagate Random.date().
11784f1 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Feb 8, 2018
@php-coder
SeriesServiceImplTest: propagate Random.listOfIntegers().
da81886 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Mar 12, 2018
@php-coder
CollectionServiceImplTest: propagate Random.userId().
cde756b 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Mar 28, 2018
@php-coder
CollectionServiceImplTest: propagate Random.userId().
e30550b 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Mar 28, 2018
@php-coder
CollectionServiceImplTest: propagate Random.id().
4ab1cfc 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Mar 28, 2018
@php-coder
CollectionServiceImplTest: propagate positiveLong().
d01eafe 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Mar 28, 2018
@php-coder
CollectionServiceImplTest: propagate bool().
1739c34 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Mar 28, 2018
@php-coder
CollectionServiceImplTest: propagate Random.quantity().
f19aee0 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Mar 28, 2018
@php-coder
CollectionServiceImplTest: propagate Random.date().
97538e9 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Jul 18, 2018
@php-coder
Use Random.categoryName() and Random.countryName().
7e332d5 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Jul 19, 2018
@php-coder
TestObjects: return random values from more methods.
3a38ffe 
Addressed to #300

No functional changes.
php-coder added a commit that referenced this issue Dec 19, 2018
@php-coder
refactor(CountryServiceImplTest): use random values in tests for sugg…
5c65fb4 
…estCountryForUser() method.

Addressed to #300
php-coder added a commit that referenced this issue Nov 4, 2019
@php-coder
chore(CategoryServiceImplTest): use random values in getStatisticsOf(…
f1790eb 
…) tests.

Address to #300
php-coder added a commit that referenced this issue Nov 5, 2019
@php-coder
refactor(CountryServiceImplTest): use random values in getStatisticsO…
2423b54 
…f() tests.

Address to #300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
area/unit tests kind/improvement
Projects
None yet
Milestone
next
Development

No branches or pull requests
1 participant
@php-coder