Skip to content

Commit 6cdd0fc

Browse files
committed
SeriesServiceImplTest(add() should pass gibbons price and currency to series dao): use random values.
Addressed to #300 No functional changes.
1 parent 5162442 commit 6cdd0fc

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/test/groovy/ru/mystamps/web/service/SeriesServiceImplTest.groovy

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -240,13 +240,13 @@ class SeriesServiceImplTest extends Specification {
240240
given:
241241
form.setMichelPrice(expectedPrice)
242242
when:
243-
service.add(form, Random.userId(), false)
243+
service.add(form, Random.userId(), bool())
244244
then:
245245
1 * seriesDao.add({ AddSeriesDbDto series ->
246246
assert series?.michelPrice == expectedPrice
247247
assert series?.michelCurrency == expectedCurrency
248248
return true
249-
}) >> 123
249+
}) >> Random.id()
250250
where:
251251
expectedPrice | expectedCurrency
252252
Random.price() | Currency.EUR.toString()
@@ -263,13 +263,13 @@ class SeriesServiceImplTest extends Specification {
263263
given:
264264
form.setScottPrice(expectedPrice)
265265
when:
266-
service.add(form, Random.userId(), false)
266+
service.add(form, Random.userId(), bool())
267267
then:
268268
1 * seriesDao.add({ AddSeriesDbDto series ->
269269
assert series?.scottPrice == expectedPrice
270270
assert series?.scottCurrency == expectedCurrency
271271
return true
272-
}) >> 123
272+
}) >> Random.id()
273273
where:
274274
expectedPrice | expectedCurrency
275275
Random.price() | Currency.USD.toString()
@@ -286,13 +286,13 @@ class SeriesServiceImplTest extends Specification {
286286
given:
287287
form.setYvertPrice(expectedPrice)
288288
when:
289-
service.add(form, Random.userId(), false)
289+
service.add(form, Random.userId(), bool())
290290
then:
291291
1 * seriesDao.add({ AddSeriesDbDto series ->
292292
assert series?.yvertPrice == expectedPrice
293293
assert series?.yvertCurrency == expectedCurrency
294294
return true
295-
}) >> 123
295+
}) >> Random.id()
296296
where:
297297
expectedPrice | expectedCurrency
298298
Random.price() | Currency.EUR.toString()
@@ -309,13 +309,13 @@ class SeriesServiceImplTest extends Specification {
309309
given:
310310
form.setGibbonsPrice(expectedPrice)
311311
when:
312-
service.add(form, Random.userId(), false)
312+
service.add(form, Random.userId(), bool())
313313
then:
314314
1 * seriesDao.add({ AddSeriesDbDto series ->
315315
assert series?.gibbonsPrice == expectedPrice
316316
assert series?.gibbonsCurrency == expectedCurrency
317317
return true
318-
}) >> 123
318+
}) >> Random.id()
319319
where:
320320
expectedPrice | expectedCurrency
321321
Random.price() | Currency.GBP.toString()

0 commit comments

Comments
 (0)