Skip to content

Commit 683489d

Browse files
committed
SeriesServiceImplTest: propagate Random.catalogNumber().
Addressed to #300 No functional changes.
1 parent 7e25158 commit 683489d

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

src/test/groovy/ru/mystamps/web/service/SeriesServiceImplTest.groovy

+12-12
Original file line numberDiff line numberDiff line change
@@ -790,7 +790,7 @@ class SeriesServiceImplTest extends Specification {
790790

791791
def "findByMichelNumber() should find series ids"() {
792792
given:
793-
String expectedNumber = '5'
793+
String expectedNumber = Random.catalogNumber()
794794
when:
795795
service.findByMichelNumber(expectedNumber, 'en')
796796
then:
@@ -801,7 +801,7 @@ class SeriesServiceImplTest extends Specification {
801801
given:
802802
michelCatalogService.findSeriesIdsByNumber(_ as String) >> []
803803
when:
804-
List<SeriesInfoDto> result = service.findByMichelNumber('5', 'en')
804+
List<SeriesInfoDto> result = service.findByMichelNumber(Random.catalogNumber(), 'en')
805805
then:
806806
0 * seriesDao.findByIdsAsSeriesInfo(_ as List, _ as String)
807807
and:
@@ -818,7 +818,7 @@ class SeriesServiceImplTest extends Specification {
818818
and:
819819
List<SeriesInfoDto> expectedResult = []
820820
when:
821-
List<SeriesInfoDto> result = service.findByMichelNumber('5', expectedLang)
821+
List<SeriesInfoDto> result = service.findByMichelNumber(Random.catalogNumber(), expectedLang)
822822
then:
823823
1 * seriesDao.findByIdsAsSeriesInfo(expectedSeriesIds, expectedLang) >> expectedResult
824824
and:
@@ -831,7 +831,7 @@ class SeriesServiceImplTest extends Specification {
831831

832832
def "findByScottNumber() should find series ids"() {
833833
given:
834-
String expectedNumber = '5'
834+
String expectedNumber = Random.catalogNumber()
835835
when:
836836
service.findByScottNumber(expectedNumber, 'en')
837837
then:
@@ -842,7 +842,7 @@ class SeriesServiceImplTest extends Specification {
842842
given:
843843
scottCatalogService.findSeriesIdsByNumber(_ as String) >> []
844844
when:
845-
List<SeriesInfoDto> result = service.findByScottNumber('5', 'en')
845+
List<SeriesInfoDto> result = service.findByScottNumber(Random.catalogNumber(), 'en')
846846
then:
847847
0 * seriesDao.findByIdsAsSeriesInfo(_ as List, _ as String)
848848
and:
@@ -859,7 +859,7 @@ class SeriesServiceImplTest extends Specification {
859859
and:
860860
List<SeriesInfoDto> expectedResult = []
861861
when:
862-
List<SeriesInfoDto> result = service.findByScottNumber('5', expectedLang)
862+
List<SeriesInfoDto> result = service.findByScottNumber(Random.catalogNumber(), expectedLang)
863863
then:
864864
1 * seriesDao.findByIdsAsSeriesInfo(expectedSeriesIds, expectedLang) >> expectedResult
865865
and:
@@ -872,7 +872,7 @@ class SeriesServiceImplTest extends Specification {
872872

873873
def "findByYvertNumber() should find series ids"() {
874874
given:
875-
String expectedNumber = '5'
875+
String expectedNumber = Random.catalogNumber()
876876
when:
877877
service.findByYvertNumber(expectedNumber, 'en')
878878
then:
@@ -883,7 +883,7 @@ class SeriesServiceImplTest extends Specification {
883883
given:
884884
yvertCatalogService.findSeriesIdsByNumber(_ as String) >> []
885885
when:
886-
List<SeriesInfoDto> result = service.findByYvertNumber('5', 'en')
886+
List<SeriesInfoDto> result = service.findByYvertNumber(Random.catalogNumber(), 'en')
887887
then:
888888
0 * seriesDao.findByIdsAsSeriesInfo(_ as List, _ as String)
889889
and:
@@ -900,7 +900,7 @@ class SeriesServiceImplTest extends Specification {
900900
and:
901901
List<SeriesInfoDto> expectedResult = []
902902
when:
903-
List<SeriesInfoDto> result = service.findByYvertNumber('5', expectedLang)
903+
List<SeriesInfoDto> result = service.findByYvertNumber(Random.catalogNumber(), expectedLang)
904904
then:
905905
1 * seriesDao.findByIdsAsSeriesInfo(expectedSeriesIds, expectedLang) >> expectedResult
906906
and:
@@ -913,7 +913,7 @@ class SeriesServiceImplTest extends Specification {
913913

914914
def "findByGibbonsNumber() should find series ids"() {
915915
given:
916-
String expectedNumber = '5'
916+
String expectedNumber = Random.catalogNumber()
917917
when:
918918
service.findByGibbonsNumber(expectedNumber, 'en')
919919
then:
@@ -924,7 +924,7 @@ class SeriesServiceImplTest extends Specification {
924924
given:
925925
gibbonsCatalogService.findSeriesIdsByNumber(_ as String) >> []
926926
when:
927-
List<SeriesInfoDto> result = service.findByGibbonsNumber('5', 'en')
927+
List<SeriesInfoDto> result = service.findByGibbonsNumber(Random.catalogNumber(), 'en')
928928
then:
929929
0 * seriesDao.findByIdsAsSeriesInfo(_ as List, _ as String)
930930
and:
@@ -941,7 +941,7 @@ class SeriesServiceImplTest extends Specification {
941941
and:
942942
List<SeriesInfoDto> expectedResult = []
943943
when:
944-
List<SeriesInfoDto> result = service.findByGibbonsNumber('5', expectedLang)
944+
List<SeriesInfoDto> result = service.findByGibbonsNumber(Random.catalogNumber(), expectedLang)
945945
then:
946946
1 * seriesDao.findByIdsAsSeriesInfo(expectedSeriesIds, expectedLang) >> expectedResult
947947
and:

0 commit comments

Comments
 (0)