-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Rebase ipython_directive on top of recent ipython updated version #5925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some early feedback (not yet tested thoroughly):
|
Thanks, I'll look at those tomorrow. |
@cpcloud , the cython fix you put in ipython_directive should find it's way upstream, |
Ok, that was very strange (and a nightmare to track down). a snippet I add long ago to faq.rst which demonstrates... monkey patching (q @jreback gloating) borked the numbering by ipython directive. Took another crack at GH5142, after rereading the issues. @jorisvandenbossche, seal of approval? |
@y-p monkey patching pandas is ok :) its just other packages BY pandas which is a problem :) |
Yep, except when that break stuff as well. case in point. |
@y-p I can't test it today anymore, but I will do tomorrow. |
Thanks, no rush. You've just proven to have a better eye for it. |
A big +1 on this! I did build the docs, and it seems good:
So as long you don't forget to put back the api docs before merging, this is looking good. |
Twice, I told myself twice to remember to get rid of that commit before pushing. sigh The coloring and Out prompts are not intentional but no harm I guess, would rather move on. I'll give the unicode bit another look, I was sure the issue was solvable. Am still holding out Thanks. |
In every case, the question marks in the output is better than not being able to build it (as long as the docs on the website are build on linux where it is not a problem). And indeed, the prompts/coloring is certainly not an issue to me, just remarked the difference. |
I don't know if it is useful, but it seems a little bit related: in matplotlib/numpydoc they had also an issue with special characters: numpy/numpydoc#1, matplotlib/matplotlib#2529 |
Rebase ipython_directive on top of recent ipython updated version
ipython/ipython#4570
We'd prefer to get rid of the duplication, but we have some tweaks in place
which ipython does not.
I rebased everythingon top of ipython to generae a clean diff, if they pick it up
we can make the transition, otherwise we synched for now.
cc @takluyver, if you're interested, check the diff between 2e3c608 and 82b8c3a
for an unobstructed view.
@jorisvandenbossche, can you check this out and let me know if I missed anything?
I included the cython magic fixes you pointed out.
related #5221